[PR #785] [MERGED] Revert `math::round_half_to_even` #1078

New issue

Closed

opened 2026-02-27 20:01:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/785
Author: @roderickvd
Created: 5/31/2021
Status: ✅ Merged
Merged: 6/1/2021
Merged by: @roderickvd

Base: dev ← Head: revert-round-half-to-even

📝 Commits (1)

d4f466e Revert math::round_half_to_even

📊 Changes

3 files changed (+13 additions, -78 deletions)

View changed files

📝 Cargo.lock (+11 -74)
📝 playback/Cargo.toml (+1 -2)
📝 playback/src/convert.rs (+1 -2)

📄 Description

This caused quite a bump in CPU usage, which would be acceptable if this actually improved sound quality. However, it turns out that this function only has one decimal precision, i.e. it would consider all values from 0.50..0.60 (exclusive) as 0.5 which is in
error for our purposes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/785 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 5/31/2021 **Status:** ✅ Merged **Merged:** 6/1/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `revert-round-half-to-even` --- ### 📝 Commits (1) - [`d4f466e`](https://github.com/librespot-org/librespot/commit/d4f466ef58b4a6128f947b1f26e7a0b020043e2a) Revert `math::round_half_to_even` ### 📊 Changes **3 files changed** (+13 additions, -78 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+11 -74) 📝 `playback/Cargo.toml` (+1 -2) 📝 `playback/src/convert.rs` (+1 -2) </details> ### 📄 Description This caused quite a bump in CPU usage, which would be acceptable if this actually improved sound quality. However, it turns out that this function only has one decimal precision, i.e. it would consider all values from `0.50..0.60` (exclusive) as `0.5` which is in error for our purposes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:04 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1078

No description provided.

Rows
Columns

[PR #785] [MERGED] Revert math::round_half_to_even #1078

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #785] [MERGED] Revert `math::round_half_to_even` #1078