[PR #778] [MERGED] Fix output on big-endian systems #1077

New issue

Closed

opened 2026-02-27 20:01:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/778
Author: @roderickvd
Created: 5/29/2021
Status: ✅ Merged
Merged: 5/30/2021
Merged by: @roderickvd

Base: dev ← Head: output-in-native-endianness

📝 Commits (5)

1f0d39d Always output in native endianness
a84348a Merge branch 'dev' into output-in-native-endianness
e4c0493 Fix clippy lints
8fa9207 Fix S24_3 on big-endian systems
0a70861 Update changelog

📊 Changes

5 files changed (+25 additions, -10 deletions)

View changed files

📝 CHANGELOG.md (+2 -0)
📝 playback/src/audio_backend/alsa.rs (+5 -1)
📝 playback/src/audio_backend/gstreamer.rs (+7 -2)
📝 playback/src/audio_backend/pulseaudio.rs (+5 -5)
📝 playback/src/convert.rs (+6 -2)

📄 Description

No idea if anyone is using librespot on big-endian systems, but this makes it so output is always in native endian format. This already was OK on the rest of the backends, and for Alsa it only concerned S24_3.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/778 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 5/29/2021 **Status:** ✅ Merged **Merged:** 5/30/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `output-in-native-endianness` --- ### 📝 Commits (5) - [`1f0d39d`](https://github.com/librespot-org/librespot/commit/1f0d39d1230653f9cc55fe34230d5790909dc9ae) Always output in native endianness - [`a84348a`](https://github.com/librespot-org/librespot/commit/a84348aeff4e9470608ba334bcb3b5bcff8496ab) Merge branch 'dev' into output-in-native-endianness - [`e4c0493`](https://github.com/librespot-org/librespot/commit/e4c04930118c6c30321b29959edb6a9ecbc19f83) Fix clippy lints - [`8fa9207`](https://github.com/librespot-org/librespot/commit/8fa92079f8b2b23b5a3a48a465a51b0330a5935f) Fix S24_3 on big-endian systems - [`0a70861`](https://github.com/librespot-org/librespot/commit/0a7086173484951f3e9169c8f8a90e71ad387d3b) Update changelog ### 📊 Changes **5 files changed** (+25 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+2 -0) 📝 `playback/src/audio_backend/alsa.rs` (+5 -1) 📝 `playback/src/audio_backend/gstreamer.rs` (+7 -2) 📝 `playback/src/audio_backend/pulseaudio.rs` (+5 -5) 📝 `playback/src/convert.rs` (+6 -2) </details> ### 📄 Description No idea if anyone is using `librespot` on big-endian systems, but this makes it so output is always in native endian format. This already was OK on the rest of the backends, and for Alsa it only concerned `S24_3`. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:37 +03:00

[PR #1077] [CLOSED] Fix latest clippy warnings on master #1223

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1077

No description provided.

Rows
Columns