starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[PR #783] [MERGED] Remove feature gate around `apresolve` #1075

New issue

Closed

opened 2026-02-27 20:01:04 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:01:04 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/783
Author: @roderickvd
Created: 5/31/2021
Status: ✅ Merged
Merged: 6/5/2021
Merged by: @roderickvd

Base: dev ← Head: remove-fallback-accesspoint

📝 Commits (1)

7c975f8 Remove feature gate around apresolve

📊 Changes

4 files changed (+4 additions, -20 deletions)

View changed files

📝 Cargo.toml (+0 -1)
📝 core/Cargo.toml (+2 -5)
📝 core/src/apresolve.rs (+1 -2)
📝 core/src/lib.rs (+1 -12)

📄 Description

The feature gate around apresolve made it so downstream packages had to opt-in, and always fell back to ap.spotify.com. It was enabled by default in librespot though.

See: https://github.com/hrkfdn/ncspot/issues/535.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/783 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 5/31/2021 **Status:** ✅ Merged **Merged:** 6/5/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `remove-fallback-accesspoint` --- ### 📝 Commits (1) - [`7c975f8`](https://github.com/librespot-org/librespot/commit/7c975f8ed0e27d0b034997cf7bacd2cd35c9c58e) Remove feature gate around `apresolve` ### 📊 Changes **4 files changed** (+4 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.toml` (+0 -1) 📝 `core/Cargo.toml` (+2 -5) 📝 `core/src/apresolve.rs` (+1 -2) 📝 `core/src/lib.rs` (+1 -12) </details> ### 📄 Description The feature gate around `apresolve` made it so downstream packages had to opt-in, and always fell back to `ap.spotify.com`. It was enabled by default in `librespot` though. See: https://github.com/hrkfdn/ncspot/issues/535. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:01:04 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:37 +03:00

[PR #1075] [MERGED] Add activate and load functions to Spirc #1221

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1075

No description provided.

Rows
Columns

[PR #783] [MERGED] Remove feature gate around apresolve #1075

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #783] [MERGED] Remove feature gate around `apresolve` #1075