starred/librespot

Fork 0

mirror of https://github.com/librespot-org/librespot.git synced 2026-04-27 08:15:50 +03:00

[PR #750] [MERGED] Remove `with-vorbis` and `with-tremor` features #1057

New issue

Closed

opened 2026-02-27 20:00:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/750
Author: @roderickvd
Created: 5/18/2021
Status: ✅ Merged
Merged: 5/26/2021
Merged by: @roderickvd

Base: dev ← Head: remove-vorbis-and-tremor

📝 Commits (3)

0cabe4a Remove with-vorbis and with-tremor features
8b7d1d4 Fix changelog
ad412e7 Merge branch 'dev' into remove-vorbis-and-tremor

📊 Changes

5 files changed (+8 additions, -93 deletions)

View changed files

📝 CHANGELOG.md (+1 -0)
📝 Cargo.lock (+0 -69)
📝 Cargo.toml (+0 -3)
📝 playback/Cargo.toml (+5 -10)
📝 playback/src/decoder/mod.rs (+2 -11)

📄 Description

As discussed in #648, recently put forward by @sashahilton00 in #734 and helpful in #727.

This may ruffle some feathers. As far as I know, LibreELEC compiles with-vorbis [1] and Spotifyd with-tremor [2]. On both accounts I don't see why. For LibreELEC I asked @heitbaum over at #681:

I just checked and compiling with-vorbis only saves 167 kB. Likewise the slight boost in performance will be neglible. At the same time, the bindings are unmaintained and only pass integer samples instead of the floats they were originally in, causing quantization error and lower sound quality. Finally, there is no Rust-unsafe code in lewton. So there's a lot to say about moving to lewton and nothing of significance for keeping libvorbis as I can see.

As for lewton, the lowest-performance hardware that librespot targets has recently been set to be Raspberry Pi Zero. Which has hard float support and so has no need for tremor. In fact even the original RPi v1 had hard float support so I can't imagine which hardware is targeted here.

Please chime in if you think this would be a bad idea.

[1] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/addons/service/librespot/package.mk
[2] https://github.com/Spotifyd/spotifyd/blob/master/Cargo.toml

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/750 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 5/18/2021 **Status:** ✅ Merged **Merged:** 5/26/2021 **Merged by:** [@roderickvd](https://github.com/roderickvd) **Base:** `dev` ← **Head:** `remove-vorbis-and-tremor` --- ### 📝 Commits (3) - [`0cabe4a`](https://github.com/librespot-org/librespot/commit/0cabe4ad73dc4f88bd0cf868aa0e113d941c5460) Remove `with-vorbis` and `with-tremor` features - [`8b7d1d4`](https://github.com/librespot-org/librespot/commit/8b7d1d43a7c2f4d59caf5870700bad2e69705d3a) Fix changelog - [`ad412e7`](https://github.com/librespot-org/librespot/commit/ad412e7e2dab8db2b6dcb21d61c574790bfdb73b) Merge branch 'dev' into remove-vorbis-and-tremor ### 📊 Changes **5 files changed** (+8 additions, -93 deletions) <details> <summary>View changed files</summary> 📝 `CHANGELOG.md` (+1 -0) 📝 `Cargo.lock` (+0 -69) 📝 `Cargo.toml` (+0 -3) 📝 `playback/Cargo.toml` (+5 -10) 📝 `playback/src/decoder/mod.rs` (+2 -11) </details> ### 📄 Description As discussed in #648, recently put forward by @sashahilton00 in #734 and helpful in #727. This may ruffle some feathers. As far as I know, `LibreELEC` compiles `with-vorbis` [1] and `Spotifyd` `with-tremor` [2]. On both accounts I don't see why. For `LibreELEC` I asked @heitbaum over at #681: > I just checked and compiling with-vorbis only saves 167 kB. Likewise the slight boost in performance will be neglible. At the same time, the bindings are unmaintained and only pass integer samples instead of the floats they were originally in, causing quantization error and lower sound quality. Finally, there is no Rust-unsafe code in lewton. So there's a lot to say about moving to lewton and nothing of significance for keeping libvorbis as I can see. As for `lewton`, the lowest-performance hardware that `librespot` targets has recently been set to be Raspberry Pi Zero. Which has hard float support and so has no need for `tremor`. In fact even the original RPi v1 had hard float support so I can't imagine which hardware is targeted here. Please chime in if you think this would be a bad idea. [1] https://github.com/LibreELEC/LibreELEC.tv/blob/master/packages/addons/service/librespot/package.mk [2] https://github.com/Spotifyd/spotifyd/blob/master/Cargo.toml --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1057

No description provided.

Rows
Columns

[PR #750] [MERGED] Remove with-vorbis and with-tremor features #1057

📋 Pull Request Information

📝 Commits (3)

📊 Changes

📄 Description

[PR #750] [MERGED] Remove `with-vorbis` and `with-tremor` features #1057