[PR #746] [MERGED] Fix warnings #1056

New issue

Closed

opened 2026-02-27 20:00:59 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:59 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/746
Author: @Johannesd3
Created: 5/13/2021
Status: ✅ Merged
Merged: 5/13/2021
Merged by: @Johannesd3

Base: dev ← Head: fix-warnings

📝 Commits (1)

2689df5 Fix warnings

📊 Changes

8 files changed (+14 additions, -11 deletions)

View changed files

📝 connect/src/spirc.rs (+1 -1)
📝 core/src/connection/handshake.rs (+1 -1)
📝 core/src/connection/mod.rs (+2 -2)
📝 core/src/mercury/mod.rs (+4 -3)
📝 core/src/spotify_id.rs (+2 -0)
📝 examples/playlist_tracks.rs (+0 -1)
📝 metadata/src/lib.rs (+2 -1)
📝 playback/src/player.rs (+2 -2)

📄 Description

Fixes the protobuf deprecation warnings (closes #723), and fixes some new clippy warnings.

I disabled the wrong_self_convention lint. There are two possible fixes: Rename some functions of SpotifyId and FileId or remove the Copy trait for those structs.

I would tend to prefer the latter, as they're quite big. 17 bytes and 20 bytes are 3 registers on 64-bit machines and requiring explicit clones wouldn't be that bad. But that's not in the scope of this little PR.

I will merge it right away if the tests pass, @sashahilton00

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/746 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 5/13/2021 **Status:** ✅ Merged **Merged:** 5/13/2021 **Merged by:** [@Johannesd3](https://github.com/Johannesd3) **Base:** `dev` ← **Head:** `fix-warnings` --- ### 📝 Commits (1) - [`2689df5`](https://github.com/librespot-org/librespot/commit/2689df5c40bc5b001a92cc3d2514706bf60fb4e0) Fix warnings ### 📊 Changes **8 files changed** (+14 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `connect/src/spirc.rs` (+1 -1) 📝 `core/src/connection/handshake.rs` (+1 -1) 📝 `core/src/connection/mod.rs` (+2 -2) 📝 `core/src/mercury/mod.rs` (+4 -3) 📝 `core/src/spotify_id.rs` (+2 -0) 📝 `examples/playlist_tracks.rs` (+0 -1) 📝 `metadata/src/lib.rs` (+2 -1) 📝 `playback/src/player.rs` (+2 -2) </details> ### 📄 Description Fixes the protobuf deprecation warnings (closes #723), and fixes some new clippy warnings. I disabled the `wrong_self_convention` lint. There are two possible fixes: Rename some functions of `SpotifyId` and `FileId` or remove the `Copy` trait for those structs. I would tend to prefer the latter, as they're quite big. 17 bytes and 20 bytes are 3 registers on 64-bit machines and requiring explicit clones wouldn't be that bad. But that's not in the scope of this little PR. I will merge it right away if the tests pass, @sashahilton00 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:59 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1056

No description provided.

Rows
Columns