mirror of
https://github.com/librespot-org/librespot.git
synced 2026-04-27 08:15:50 +03:00
[GH-ISSUE #132] Apply rustfmt to librespot-core and enforce it on travis #104
Labels
No labels
A-Alsa
SpotifyAPI
Tokio 1.0
audio
bug
can't reproduce
compilation
dependencies
duplicate
enhancement
good first issue
help wanted
high priority
imported
imported
invalid
new api
pull-request
question
reverse engineering
wiki
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot#104
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @plietar on GitHub (Feb 8, 2018).
Original GitHub issue: https://github.com/librespot-org/librespot/issues/132
From what I've heard rustfmt is good enough now for this to be possible.
In most places librespot already uses the standard style, so the initial diff shouldn't be that bad.
@sashahilton00 commented on GitHub (Feb 10, 2018):
Just had a look at rustfmt, and it looks as though it's good to go on beta and nightly builds, and getting there on rust 1.24.0. Do we think the requirements for rust => 1.24.0 are worth it for adding rustfmt to the project?
@plietar commented on GitHub (Feb 11, 2018):
@sashahilton00 Contributors would need to have nightly locally so they can run rustfmt, but people who are just building don't need anything.
@sashahilton00 commented on GitHub (Feb 11, 2018):
Ok, could we perhaps add a brief note about contributors needing mightly, what rustfmt is, and what contributors need to run to the wiki? I can look at the website and work it out, but I feel like those who are just looking to help here and there probably aren't going to want to learn all about it, but rather have a brief overview of what it does, and what commands they need to run before committing.
@awiouy commented on GitHub (Feb 11, 2018):
To use rustfmt:
Use atom and run rustfmt from atom as described here.
@kingosticks commented on GitHub (Feb 11, 2018):
It'd be helpful to have a general note for those that don't use atom.
@sashahilton00 commented on GitHub (Feb 11, 2018):
Hmmm, I'm still hesitant about this; although Atom is popular (I use it as well), I'm not sure our solution to adding rustfmt and enforcing it on travis should be 'use this IDE or go hunting around the web for some other instructions. Is there no way to execute rustfmt on the cli to show a list of changes that should be made?
@ComlOnline commented on GitHub (Feb 14, 2018):
There is a suggestion to use nightly in the wiki, but something about how to use rustfmt would be handy.
I use VS-Code and it has an addon for rustfmt as well as a bunch of others I've found after a google (vim, emacs and Sublime)
As for running from command line have a look here.
But be warned the default mode is overwrite, see here for more modes.
EDIT: There is even a bit about editors