[PR #709] [CLOSED] Revert "Use `ready!` macro to reduce boilerplate" #1033

New issue

Closed

opened 2026-02-27 20:00:54 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:54 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/709
Author: @sashahilton00
Created: 5/1/2021
Status: ❌ Closed

Base: dev ← Head: revert-699-ready-macro

📝 Commits (1)

b5e1568 Revert "Use ready! macro to reduce boilerplate"

📊 Changes

3 files changed (+47 additions, -16 deletions)

View changed files

📝 core/src/channel.rs (+36 -9)
📝 core/src/mercury/mod.rs (+5 -2)
📝 core/src/session.rs (+6 -5)

📄 Description

Reverts librespot-org/librespot#699. Same mistake as #708.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/709 **Author:** [@sashahilton00](https://github.com/sashahilton00) **Created:** 5/1/2021 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `revert-699-ready-macro` --- ### 📝 Commits (1) - [`b5e1568`](https://github.com/librespot-org/librespot/commit/b5e156822da214b6245106aefd3af455f058b9aa) Revert "Use `ready!` macro to reduce boilerplate" ### 📊 Changes **3 files changed** (+47 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `core/src/channel.rs` (+36 -9) 📝 `core/src/mercury/mod.rs` (+5 -2) 📝 `core/src/session.rs` (+6 -5) </details> ### 📄 Description Reverts librespot-org/librespot#699. Same mistake as #708. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:54 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1033

No description provided.

Rows
Columns

[PR #709] [CLOSED] Revert "Use ready! macro to reduce boilerplate" #1033

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #709] [CLOSED] Revert "Use `ready!` macro to reduce boilerplate" #1033