[PR #714] [MERGED] Unpin protobuf version #1032

Closed
opened 2026-02-27 20:00:54 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/714
Author: @Johannesd3
Created: 5/4/2021
Status: Merged
Merged: 5/8/2021
Merged by: @Johannesd3

Base: devHead: protobuf-version


📝 Commits (1)

📊 Changes

6 files changed (+11 additions, -15 deletions)

View changed files

📝 Cargo.lock (+6 -7)
📝 connect/Cargo.toml (+1 -1)
📝 core/Cargo.toml (+1 -1)
📝 metadata/Cargo.toml (+1 -1)
📝 protocol/Cargo.toml (+2 -3)
📝 protocol/build.rs (+0 -2)

📄 Description

The version of protobuf was unnecessarily pinned. There were some issues (#460), but e97911e3cf fixed them. It remained pinned only because of the MSRV 1.40 at that time.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/714 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 5/4/2021 **Status:** ✅ Merged **Merged:** 5/8/2021 **Merged by:** [@Johannesd3](https://github.com/Johannesd3) **Base:** `dev` ← **Head:** `protobuf-version` --- ### 📝 Commits (1) - [`1c62af9`](https://github.com/librespot-org/librespot/commit/1c62af916078919616c505e45a92ac452c10b94e) Unpin protobuf version ### 📊 Changes **6 files changed** (+11 additions, -15 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+6 -7) 📝 `connect/Cargo.toml` (+1 -1) 📝 `core/Cargo.toml` (+1 -1) 📝 `metadata/Cargo.toml` (+1 -1) 📝 `protocol/Cargo.toml` (+2 -3) 📝 `protocol/build.rs` (+0 -2) </details> ### 📄 Description The version of protobuf was unnecessarily pinned. There were some issues (#460), but e97911e3cfcb85b524e844d0ef5417bbee1e4970 fixed them. It remained pinned only because of the MSRV 1.40 at that time. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-02-27 20:00:54 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot#1032
No description provided.