[PR #699] [MERGED] Use `ready!` macro to reduce boilerplate #1028

New issue

Closed

opened 2026-02-27 20:00:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/699
Author: @Johannesd3
Created: 4/17/2021
Status: ✅ Merged
Merged: 5/1/2021
Merged by: @sashahilton00

Base: dev ← Head: ready-macro

📝 Commits (1)

7d6267c Use ready macro to reduce boilerplate

📊 Changes

3 files changed (+16 additions, -47 deletions)

View changed files

📝 core/src/channel.rs (+9 -36)
📝 core/src/mercury/mod.rs (+2 -5)
📝 core/src/session.rs (+5 -6)

📄 Description

I just realized this macro exists. In conjunction with the ? operator it makes a lot of boilerplate match expressions redundant.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/699 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 4/17/2021 **Status:** ✅ Merged **Merged:** 5/1/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `ready-macro` --- ### 📝 Commits (1) - [`7d6267c`](https://github.com/librespot-org/librespot/commit/7d6267c0a2bea1218af5faac2918ac113ab1a91c) Use ready macro to reduce boilerplate ### 📊 Changes **3 files changed** (+16 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `core/src/channel.rs` (+9 -36) 📝 `core/src/mercury/mod.rs` (+2 -5) 📝 `core/src/session.rs` (+5 -6) </details> ### 📄 Description I just realized this macro exists. In conjunction with the `?` operator it makes a lot of boilerplate `match` expressions redundant. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:52 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1028

No description provided.

Rows
Columns

[PR #699] [MERGED] Use ready! macro to reduce boilerplate #1028

📋 Pull Request Information

📝 Commits (1)

📊 Changes

📄 Description

[PR #699] [MERGED] Use `ready!` macro to reduce boilerplate #1028