[PR #698] [MERGED] Fix basic normalisation #1026

New issue

Closed

opened 2026-02-27 20:00:52 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:52 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/698
Author: @roderickvd
Created: 4/16/2021
Status: ✅ Merged
Merged: 4/23/2021
Merged by: @sashahilton00

Base: dev ← Head: fix-basic-normalisation

📝 Commits (2)

ffa284c Fix basic volume normalisation
d44b74e Add dB unit in warning message

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 playback/src/player.rs (+3 -3)

📄 Description

b4f9ae31e2 unintentionally broke the basic limiter by testing for equality instead of inequality. In case of the basic limiter, it should confirm that normalisation_factor <> 1.0 or else don't bother iterating over the samples. This fixes that and slightly changes the if statement to better state that intention.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/698 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 4/16/2021 **Status:** ✅ Merged **Merged:** 4/23/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `fix-basic-normalisation` --- ### 📝 Commits (2) - [`ffa284c`](https://github.com/librespot-org/librespot/commit/ffa284c42a82b2257efc8e1bb570d03039acd3da) Fix basic volume normalisation - [`d44b74e`](https://github.com/librespot-org/librespot/commit/d44b74ea57cee2f0eee91694a72bd15cf3af9934) Add dB unit in warning message ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `playback/src/player.rs` (+3 -3) </details> ### 📄 Description b4f9ae31e2832ba6c0bd753eeb36902dd2cb07cc unintentionally broke the basic limiter by testing for equality instead of inequality. In case of the basic limiter, it should confirm that `normalisation_factor <> 1.0` or else don't bother iterating over the samples. This fixes that and slightly changes the `if` statement to better state that intention. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:52 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:32 +03:00

[PR #1026] [MERGED] Blacklist ap-gew4 access point #1197

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1026

No description provided.

Rows
Columns