[PR #691] [MERGED] [Tokio migration] Better joining of session tasks #1023

New issue

Closed

opened 2026-02-27 20:00:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/691
Author: @Johannesd3
Created: 4/12/2021
Status: ✅ Merged
Merged: 4/13/2021
Merged by: @sashahilton00

Base: dev ← Head: tokio_migration

📝 Commits (1)

4c2fc61 Better joining of session tasks

📊 Changes

1 file changed (+9 additions, -4 deletions)

View changed files

📝 core/src/session.rs (+9 -4)

📄 Description

Just a very little PR: If either sender_task or receiver_task fails, the other task will be cancelled and the error will be printed. This should be closer to the behaviour before the migration.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/691 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 4/12/2021 **Status:** ✅ Merged **Merged:** 4/13/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `tokio_migration` --- ### 📝 Commits (1) - [`4c2fc61`](https://github.com/librespot-org/librespot/commit/4c2fc61d64694e06b62c3a81d28e2bc183aa1be4) Better joining of session tasks ### 📊 Changes **1 file changed** (+9 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `core/src/session.rs` (+9 -4) </details> ### 📄 Description Just a very little PR: If either `sender_task` or `receiver_task` fails, the other task will be cancelled and the error will be printed. This should be closer to the behaviour before the migration. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:51 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:32 +03:00

[PR #1023] [MERGED] related project: snapcast #1196

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1023

No description provided.

Rows
Columns