[PR #692] [MERGED] Move decoder to playback crate #1020

New issue

Closed

opened 2026-02-27 20:00:51 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:51 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/692
Author: @Johannesd3
Created: 4/13/2021
Status: ✅ Merged
Merged: 5/11/2021
Merged by: @sashahilton00

Base: dev ← Head: move-decoder-to-playback

📝 Commits (1)

555274b Move decoder to playback crate

📊 Changes

25 files changed (+116 additions, -111 deletions)

View changed files

📝 .github/workflows/test.yml (+0 -1)
📝 CHANGELOG.md (+4 -0)
📝 Cargo.lock (+5 -6)
📝 Cargo.toml (+2 -2)
📝 audio/Cargo.toml (+0 -11)
📝 audio/src/lib.rs (+0 -77)
📝 playback/Cargo.toml (+11 -1)
📝 playback/src/audio_backend/alsa.rs (+1 -1)
📝 playback/src/audio_backend/gstreamer.rs (+1 -1)
📝 playback/src/audio_backend/jackaudio.rs (+1 -1)
📝 playback/src/audio_backend/mod.rs (+2 -2)
📝 playback/src/audio_backend/pipe.rs (+1 -1)
📝 playback/src/audio_backend/portaudio.rs (+2 -1)
📝 playback/src/audio_backend/pulseaudio.rs (+1 -1)
📝 playback/src/audio_backend/rodio.rs (+2 -1)
📝 playback/src/audio_backend/sdl.rs (+2 -1)
📝 playback/src/audio_backend/subprocess.rs (+1 -1)
📝 playback/src/config.rs (+1 -1)
📝 playback/src/convert.rs (+0 -0)
📝 playback/src/decoder/lewton_decoder.rs (+0 -0)

...and 5 more files

📄 Description

Here's a PR that suggests moving the decoders and @roderickvd's new convert module to librespot-playback, which is the only crate that uses this stuff. Decoding is not Spotify-specific, and librespot should not expose thin wrappers for Vorbis decoders IMO.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/692 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 4/13/2021 **Status:** ✅ Merged **Merged:** 5/11/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `move-decoder-to-playback` --- ### 📝 Commits (1) - [`555274b`](https://github.com/librespot-org/librespot/commit/555274b5afeee5ea0e271fbe50ee535fa48d4ea9) Move decoder to playback crate ### 📊 Changes **25 files changed** (+116 additions, -111 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+0 -1) 📝 `CHANGELOG.md` (+4 -0) 📝 `Cargo.lock` (+5 -6) 📝 `Cargo.toml` (+2 -2) 📝 `audio/Cargo.toml` (+0 -11) 📝 `audio/src/lib.rs` (+0 -77) 📝 `playback/Cargo.toml` (+11 -1) 📝 `playback/src/audio_backend/alsa.rs` (+1 -1) 📝 `playback/src/audio_backend/gstreamer.rs` (+1 -1) 📝 `playback/src/audio_backend/jackaudio.rs` (+1 -1) 📝 `playback/src/audio_backend/mod.rs` (+2 -2) 📝 `playback/src/audio_backend/pipe.rs` (+1 -1) 📝 `playback/src/audio_backend/portaudio.rs` (+2 -1) 📝 `playback/src/audio_backend/pulseaudio.rs` (+1 -1) 📝 `playback/src/audio_backend/rodio.rs` (+2 -1) 📝 `playback/src/audio_backend/sdl.rs` (+2 -1) 📝 `playback/src/audio_backend/subprocess.rs` (+1 -1) 📝 `playback/src/config.rs` (+1 -1) 📝 `playback/src/convert.rs` (+0 -0) 📝 `playback/src/decoder/lewton_decoder.rs` (+0 -0) _...and 5 more files_ </details> ### 📄 Description Here's a PR that suggests moving the decoders and @roderickvd's new `convert` module to `librespot-playback`, which is the only crate that uses this stuff. Decoding is not Spotify-specific, and librespot should not expose thin wrappers for Vorbis decoders IMO. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:51 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:31 +03:00

[PR #1020] [MERGED] Improve pipe backend #1194

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1020

No description provided.

Rows
Columns