[PR #684] [MERGED] Log error instead of panicking when child fails to start #1015

New issue

Closed

opened 2026-02-27 20:00:50 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:50 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/684
Author: @roderickvd
Created: 3/31/2021
Status: ✅ Merged
Merged: 5/1/2021
Merged by: @sashahilton00

Base: dev ← Head: fix-onevent-panic

📝 Commits (2)

0149725 Log error instead of panicking when child fails to start
78850dd Merge remote-tracking branch 'upstream/dev' into fix-onevent-panic

📊 Changes

1 file changed (+13 additions, -8 deletions)

View changed files

📝 src/main.rs (+13 -8)

📄 Description

librespot currently panics when onevent programs fail to start, which seems a bit harsh -- there's nothing in the way of resuming music streaming. This PR handles this gracefully.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/684 **Author:** [@roderickvd](https://github.com/roderickvd) **Created:** 3/31/2021 **Status:** ✅ Merged **Merged:** 5/1/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `fix-onevent-panic` --- ### 📝 Commits (2) - [`0149725`](https://github.com/librespot-org/librespot/commit/0149725d772d6e840c15eed08f76646fd4ecbc74) Log error instead of panicking when child fails to start - [`78850dd`](https://github.com/librespot-org/librespot/commit/78850dd45bdda3ae279ad86e1a42dd4794c68a79) Merge remote-tracking branch 'upstream/dev' into fix-onevent-panic ### 📊 Changes **1 file changed** (+13 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/main.rs` (+13 -8) </details> ### 📄 Description librespot currently panics when `onevent` programs fail to start, which seems a bit harsh -- there's nothing in the way of resuming music streaming. This PR handles this gracefully. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:50 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:31 +03:00

[PR #1015] [MERGED] Fix --opt=value line argument logging #1191

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1015

No description provided.

Rows
Columns