[PR #674] [MERGED] [Tokio migration] Add back hyper-proxy #1010

New issue

Closed

opened 2026-02-27 20:00:49 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:49 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/674
Author: @Johannesd3
Created: 3/17/2021
Status: ✅ Merged
Merged: 3/29/2021
Merged by: @ashthespy

Base: tokio_migration ← Head: proxy-support

📝 Commits (1)

95fedf5 Add back hyper-proxy

📊 Changes

8 files changed (+168 additions, -187 deletions)

View changed files

📝 Cargo.lock (+63 -38)
📝 Cargo.toml (+0 -1)
📝 core/Cargo.toml (+3 -3)
📝 core/src/apresolve.rs (+53 -58)
📝 core/src/connection/mod.rs (+30 -23)
📝 core/src/lib.rs (+12 -3)
📝 core/src/proxytunnel.rs (+4 -58)
📝 core/src/session.rs (+3 -3)

📄 Description

This PR adds back the latest version of hyper-proxy. (It was removed as the migration to tokio was not finished yet). I also restored the old behaviour in some places I believe my refactoring was too eager.

I think it is the last major step before #665 is ready. ~~Unfortunately, it is blocked by tafia/hyper-proxy#23.~~

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/674 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 3/17/2021 **Status:** ✅ Merged **Merged:** 3/29/2021 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `tokio_migration` ← **Head:** `proxy-support` --- ### 📝 Commits (1) - [`95fedf5`](https://github.com/librespot-org/librespot/commit/95fedf53573c09683b49de4801bcbc46345ff9f4) Add back hyper-proxy ### 📊 Changes **8 files changed** (+168 additions, -187 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+63 -38) 📝 `Cargo.toml` (+0 -1) 📝 `core/Cargo.toml` (+3 -3) 📝 `core/src/apresolve.rs` (+53 -58) 📝 `core/src/connection/mod.rs` (+30 -23) 📝 `core/src/lib.rs` (+12 -3) 📝 `core/src/proxytunnel.rs` (+4 -58) 📝 `core/src/session.rs` (+3 -3) </details> ### 📄 Description This PR adds back the latest version of hyper-proxy. (It was removed as the migration to tokio was not finished yet). I also restored the old behaviour in some places I believe my refactoring was too eager. I think it is the last major step before #665 is ready. ~Unfortunately, it is blocked by tafia/hyper-proxy#23.~ --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:49 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1010

No description provided.

Rows
Columns