[PR #667] [MERGED] Fix remaining clippy warnings #1008

New issue

Closed

opened 2026-02-27 20:00:48 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/667
Author: @Johannesd3
Created: 3/10/2021
Status: ✅ Merged
Merged: 3/11/2021
Merged by: @ashthespy

Base: tokio_migration ← Head: small-fixes

📝 Commits (2)

5616004 Fix many clippy lints
059b902 Remove redundant field names

📊 Changes

9 files changed (+95 additions, -108 deletions)

View changed files

📝 README.md (+1 -1)
📝 connect/src/discovery.rs (+6 -9)
📝 connect/src/spirc.rs (+18 -19)
📝 core/src/channel.rs (+5 -4)
📝 core/src/connection/handshake.rs (+4 -4)
📝 metadata/src/lib.rs (+13 -14)
📝 playback/src/mixer/mod.rs (+3 -1)
📝 playback/src/player.rs (+23 -28)
📝 src/main.rs (+22 -28)

📄 Description

Fix the remaining clippy warnings and some other small improvements. Nothing spectacular.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/667 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 3/10/2021 **Status:** ✅ Merged **Merged:** 3/11/2021 **Merged by:** [@ashthespy](https://github.com/ashthespy) **Base:** `tokio_migration` ← **Head:** `small-fixes` --- ### 📝 Commits (2) - [`5616004`](https://github.com/librespot-org/librespot/commit/5616004dbec3836b9382494312766eda6c3186de) Fix many clippy lints - [`059b902`](https://github.com/librespot-org/librespot/commit/059b9029ded1ac7d08efdef3ec1e841d33b0b5ef) Remove redundant field names ### 📊 Changes **9 files changed** (+95 additions, -108 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -1) 📝 `connect/src/discovery.rs` (+6 -9) 📝 `connect/src/spirc.rs` (+18 -19) 📝 `core/src/channel.rs` (+5 -4) 📝 `core/src/connection/handshake.rs` (+4 -4) 📝 `metadata/src/lib.rs` (+13 -14) 📝 `playback/src/mixer/mod.rs` (+3 -1) 📝 `playback/src/player.rs` (+23 -28) 📝 `src/main.rs` (+22 -28) </details> ### 📄 Description Fix the remaining clippy warnings and some other small improvements. Nothing spectacular. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:48 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1008

No description provided.

Rows
Columns