[PR #664] [MERGED] separated stream for each seek #1005

New issue

Closed

opened 2026-02-27 20:00:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/664
Author: @philippe44
Created: 3/6/2021
Status: ✅ Merged
Merged: 4/9/2021
Merged by: @sashahilton00

Base: dev ← Head: passthrough-update

📝 Commits (2)

8dc1e80 separated stream for each seek
86dbaa8 true/false don't need to be explicit

📊 Changes

1 file changed (+92 additions, -79 deletions)

View changed files

📝 audio/src/passthrough_decoder.rs (+92 -79)

📄 Description

Per https://github.com/librespot-org/librespot/issues/654 it's probably a better idea to have a separated stream every time the user seeks through the same track. It also makes code simpler and solves the issue with potentially missing BoS. The only case where the EoS might miss is when skipping tracks.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/664 **Author:** [@philippe44](https://github.com/philippe44) **Created:** 3/6/2021 **Status:** ✅ Merged **Merged:** 4/9/2021 **Merged by:** [@sashahilton00](https://github.com/sashahilton00) **Base:** `dev` ← **Head:** `passthrough-update` --- ### 📝 Commits (2) - [`8dc1e80`](https://github.com/librespot-org/librespot/commit/8dc1e80633cccebed2a28224d8e43b19047d747e) separated stream for each seek - [`86dbaa8`](https://github.com/librespot-org/librespot/commit/86dbaa8ed53c5b76414d1a577f680d2a65dd2c89) true/false don't need to be explicit ### 📊 Changes **1 file changed** (+92 additions, -79 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/passthrough_decoder.rs` (+92 -79) </details> ### 📄 Description Per https://github.com/librespot-org/librespot/issues/654 it's probably a better idea to have a separated stream every time the user seeks through the same track. It also makes code simpler and solves the issue with potentially missing BoS. The only case where the EoS might miss is when skipping tracks. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:47 +03:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1005

No description provided.

Rows
Columns