[PR #659] [CLOSED] Throttle playback #1004

New issue

Closed

opened 2026-02-27 20:00:47 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 20:00:47 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/librespot-org/librespot/pull/659
Author: @Johannesd3
Created: 3/1/2021
Status: ❌ Closed

Base: dev ← Head: pipe-throttling

📝 Commits (2)

02c6a49 Throttle playback
c7c528c Fix formatting

📊 Changes

5 files changed (+51 additions, -51 deletions)

View changed files

📝 audio/src/lewton_decoder.rs (+1 -1)
📝 audio/src/lib.rs (+15 -8)
📝 audio/src/passthrough_decoder.rs (+6 -2)
📝 playback/src/audio_backend/pipe.rs (+2 -2)
📝 playback/src/player.rs (+27 -38)

📄 Description

This is a quick attempt to fix #521. If the player is too far ahead, it lets the thread sleep for a while.

I'm not sure at which treshold and how long I should sleep, and I don't know if this works with every backend and with --passthrough. Nevertheless I would like to hear your opinions.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/librespot-org/librespot/pull/659 **Author:** [@Johannesd3](https://github.com/Johannesd3) **Created:** 3/1/2021 **Status:** ❌ Closed **Base:** `dev` ← **Head:** `pipe-throttling` --- ### 📝 Commits (2) - [`02c6a49`](https://github.com/librespot-org/librespot/commit/02c6a49c7971fa52d514f88c679a66e558b4e37d) Throttle playback - [`c7c528c`](https://github.com/librespot-org/librespot/commit/c7c528cec13e42cc48a642967aed60da08196e75) Fix formatting ### 📊 Changes **5 files changed** (+51 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `audio/src/lewton_decoder.rs` (+1 -1) 📝 `audio/src/lib.rs` (+15 -8) 📝 `audio/src/passthrough_decoder.rs` (+6 -2) 📝 `playback/src/audio_backend/pipe.rs` (+2 -2) 📝 `playback/src/player.rs` (+27 -38) </details> ### 📄 Description This is a quick attempt to fix #521. If the player is too far ahead, it lets the thread sleep for a while. I'm not sure at which treshold and how long I should sleep, and I don't know if this works with every backend and with `--passthrough`. Nevertheless I would like to hear your opinions. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

kerem

2026-02-27 20:00:47 +03:00

closed this issue
added the
pull-request
label

kerem referenced this issue

2026-02-27 20:01:29 +03:00

[PR #1004] [MERGED] Update crates #1184

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/librespot#1004

No description provided.

Rows
Columns