[PR #312] [MERGED] Improve Login5 Implementation #316

New issue

Closed

opened 2026-02-27 08:12:42 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:12:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kokarare1212/librespot-python/pull/312
Author: @Googolplexed0
Created: 8/23/2025
Status: ✅ Merged
Merged: 8/23/2025
Merged by: @kokarare1212

Base: main ← Head: login5-refresh

📝 Commits (2)

9a77766 move all login5 logic into TokenProvider
5d0784e rename Identifiers_pb2 to fix https://github.com/Googolplexed0/zotify/issues/58

📊 Changes

3 files changed (+45 additions, -59 deletions)

View changed files

📝 librespot/core.py (+44 -58)
📝 librespot/proto/spotify/login5/v3/Login5_pb2.py (+1 -1)
📝 librespot/proto/spotify/login5/v3/identifiers/Identifiers_pb2.py (+0 -0)

📄 Description

I meant it when I said previously "I can't confirm it is 100% bug free". This fixes a few bugs some other users experienced and is overall a large improvement to the previous implementation (that was rather rushed).

Changes:

Move all login5 logic out of Session and into TokenProvider
Allow for login5 token refresh after expiry
Fix legacy protobuf naming that may cause import errors
Slightly improved logging

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kokarare1212/librespot-python/pull/312 **Author:** [@Googolplexed0](https://github.com/Googolplexed0) **Created:** 8/23/2025 **Status:** ✅ Merged **Merged:** 8/23/2025 **Merged by:** [@kokarare1212](https://github.com/kokarare1212) **Base:** `main` ← **Head:** `login5-refresh` --- ### 📝 Commits (2) - [`9a77766`](https://github.com/kokarare1212/librespot-python/commit/9a7776667f7dc5e967d75170a86b5c7f2e0e3eab) move all login5 logic into TokenProvider - [`5d0784e`](https://github.com/kokarare1212/librespot-python/commit/5d0784e1c99d72e6c99f38023eca0c5bb9643a8e) rename Identifiers_pb2 to fix https://github.com/Googolplexed0/zotify/issues/58 ### 📊 Changes **3 files changed** (+45 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `librespot/core.py` (+44 -58) 📝 `librespot/proto/spotify/login5/v3/Login5_pb2.py` (+1 -1) 📝 `librespot/proto/spotify/login5/v3/identifiers/Identifiers_pb2.py` (+0 -0) </details> ### 📄 Description I meant it when I said previously "[I can't confirm it is 100% bug free](https://github.com/kokarare1212/librespot-python/pull/311#issue-3327894639)". This fixes a few bugs some other users experienced and is overall a large improvement to the previous implementation (that was rather rushed). ## Changes: ## - Move all login5 logic out of Session and into TokenProvider - Allow for login5 token refresh after expiry - Fix legacy protobuf naming that may cause import errors - Slightly improved logging --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>