[PR #242] [CLOSED] Bug fixes and Code Refactoring #265

New issue

Closed

opened 2026-02-27 08:12:31 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:12:31 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kokarare1212/librespot-python/pull/242
Author: @Advik-B
Created: 10/24/2023
Status: ❌ Closed

Base: main ← Head: main

📝 Commits (8)

b598717 'Refactored by Sourcery'
e551ce5 Merge pull request #1 from Advik-B/sourcery/main
17a4f46 Hotfix: 1
784f0ff Disable SSL verification
e8b11fd Remove unreachable code and final hotfix
0c3aa8d Update init.py
18a42ec Merge branch 'kokarare1212:main' into main
9e68c89 Update init.py

📊 Changes

15 files changed (+336 additions, -356 deletions)

View changed files

📝 examples/player/main.py (+13 -20)
📝 examples/server/main.py (+45 -39)
📝 librespot/__init__.py (+1 -1)
📝 librespot/audio/__init__.py (+76 -64)
📝 librespot/audio/decoders.py (+18 -15)
📝 librespot/audio/decrypt.py (+2 -2)
📝 librespot/audio/format.py (+1 -1)
📝 librespot/audio/storage.py (+8 -9)
📝 librespot/core.py (+76 -112)
📝 librespot/crypto.py (+13 -8)
📝 librespot/mercury.py (+19 -20)
📝 librespot/metadata.py (+23 -25)
📝 librespot/util.py (+2 -2)
📝 librespot/zeroconf.py (+27 -29)
📝 librespot_player/__init__.py (+12 -9)

📄 Description

The base code refactoring is provided by Sourcery https://github.com/Advik-B/librespot-python/pull/1

Hotfix 1: Fix SSL warning/error github.com/kokarare1212/librespot-python@17a4f4626b github.com/kokarare1212/librespot-python@784f0ff93f

Hotfix 2: Fixing a parsing error https://github.com/jsavargas/zspotify/issues/149#issuecomment-1773865540

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kokarare1212/librespot-python/pull/242 **Author:** [@Advik-B](https://github.com/Advik-B) **Created:** 10/24/2023 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (8) - [`b598717`](https://github.com/kokarare1212/librespot-python/commit/b5987179e24c1ec3b18d9bd9a44521d7c0cad47a) 'Refactored by Sourcery' - [`e551ce5`](https://github.com/kokarare1212/librespot-python/commit/e551ce526b9805c77248b0f1213a20e22a4553fb) Merge pull request #1 from Advik-B/sourcery/main - [`17a4f46`](https://github.com/kokarare1212/librespot-python/commit/17a4f4626b599725df0a4483ff993978e5aa75f5) Hotfix: 1 - [`784f0ff`](https://github.com/kokarare1212/librespot-python/commit/784f0ff93f7d2cf8edfdb0a389a2ca2571d249fe) Disable SSL verification - [`e8b11fd`](https://github.com/kokarare1212/librespot-python/commit/e8b11fd0ddd1c4deb5a8b87645a0059c79ec9ccf) Remove unreachable code and final hotfix - [`0c3aa8d`](https://github.com/kokarare1212/librespot-python/commit/0c3aa8d7d150b935b5d213b3dc4c11a1e587b774) Update __init__.py - [`18a42ec`](https://github.com/kokarare1212/librespot-python/commit/18a42ec42c91707ec0a45e5bdb80a211c5b49c91) Merge branch 'kokarare1212:main' into main - [`9e68c89`](https://github.com/kokarare1212/librespot-python/commit/9e68c89a69fbcc7a60026690e9f6940c80a02ea5) Update __init__.py ### 📊 Changes **15 files changed** (+336 additions, -356 deletions) <details> <summary>View changed files</summary> 📝 `examples/player/main.py` (+13 -20) 📝 `examples/server/main.py` (+45 -39) 📝 `librespot/__init__.py` (+1 -1) 📝 `librespot/audio/__init__.py` (+76 -64) 📝 `librespot/audio/decoders.py` (+18 -15) 📝 `librespot/audio/decrypt.py` (+2 -2) 📝 `librespot/audio/format.py` (+1 -1) 📝 `librespot/audio/storage.py` (+8 -9) 📝 `librespot/core.py` (+76 -112) 📝 `librespot/crypto.py` (+13 -8) 📝 `librespot/mercury.py` (+19 -20) 📝 `librespot/metadata.py` (+23 -25) 📝 `librespot/util.py` (+2 -2) 📝 `librespot/zeroconf.py` (+27 -29) 📝 `librespot_player/__init__.py` (+12 -9) </details> ### 📄 Description The base code refactoring is provided by Sourcery https://github.com/Advik-B/librespot-python/pull/1 Hotfix 1: Fix SSL warning/error https://github.com/kokarare1212/librespot-python/commit/17a4f4626b599725df0a4483ff993978e5aa75f5 https://github.com/kokarare1212/librespot-python/commit/784f0ff93f7d2cf8edfdb0a389a2ca2571d249fe Hotfix 2: Fixing a parsing error https://github.com/jsavargas/zspotify/issues/149#issuecomment-1773865540 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>