[PR #43] [MERGED] Fixed the _pb2 suffix need for protobuf compiled files and also fixed issue with proxy configuration in requests Session #104

New issue

Closed

opened 2026-02-27 08:11:56 +03:00 by kerem · 0 comments

kerem commented

2026-02-27 08:11:56 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kokarare1212/librespot-python/pull/43
Author: @pawanpaudel93
Created: 5/26/2021
Status: ✅ Merged
Merged: 5/26/2021
Merged by: @kokarare1212

Base: main ← Head: main

📝 Commits (5)

0214721 fixed the _pb2 suffix error and import errors
3a38afe fixing import errors
81cbd5a fixing proxy configuration with and without auth
3fcf78e importing the compiled pb2 modules with alias
3b8068a fixed class use insted of module

📊 Changes

51 files changed (+87 additions, -91 deletions)

View changed files

📝 librespot/Version.py (+1 -1)
📝 librespot/ZeroconfServer.py (+1 -1)
📝 librespot/audio/AudioKeyManager.py (+2 -2)
📝 librespot/audio/GeneralAudioStream.py (+1 -1)
📝 librespot/audio/PlayableContentFeeder.py (+9 -9)
📝 librespot/audio/StreamId.py (+1 -1)
📝 librespot/audio/__init__.py (+8 -8)
📝 librespot/audio/cdn/CdnFeedHelper.py (+7 -7)
📝 librespot/audio/cdn/CdnManager.py (+5 -5)
📝 librespot/audio/decoders/AudioQuality.py (+1 -1)
📝 librespot/audio/format/AudioQualityPicker.py (+1 -1)
📝 librespot/audio/format/SuperAudioFormat.py (+1 -1)
📝 librespot/audio/storage/ChannelManager.py (+1 -1)
📝 librespot/core/Session.py (+15 -18)
📝 librespot/dealer/ApiClient.py (+2 -2)
📝 librespot/mercury/MercuryClient.py (+2 -2)
📝 librespot/mercury/RawMercuryRequest.py (+1 -1)
📝 librespot/metadata/__init__.py (+5 -5)
📝 librespot/player/StateWrapper.py (+5 -5)
📝 librespot/player/codecs/VorbisOnlyAudioQuality.py (+1 -1)

...and 31 more files

📄 Description

The below error was shown when using the package in Ubuntu 20.04 and _pb2 suffix was needed to fix the error for the compiled files and also there was an error in the proxy configuration in Session.py.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kokarare1212/librespot-python/pull/43 **Author:** [@pawanpaudel93](https://github.com/pawanpaudel93) **Created:** 5/26/2021 **Status:** ✅ Merged **Merged:** 5/26/2021 **Merged by:** [@kokarare1212](https://github.com/kokarare1212) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (5) - [`0214721`](https://github.com/kokarare1212/librespot-python/commit/0214721dd7949b3380669b8eaf18c1e1a4695792) fixed the _pb2 suffix error and import errors - [`3a38afe`](https://github.com/kokarare1212/librespot-python/commit/3a38afeef0422bb46e6959e5b4af2a85d1434fc5) fixing import errors - [`81cbd5a`](https://github.com/kokarare1212/librespot-python/commit/81cbd5a588502c5a718072991b3b2d7e7d24879f) fixing proxy configuration with and without auth - [`3fcf78e`](https://github.com/kokarare1212/librespot-python/commit/3fcf78eb2313511f57f201b1826170d8fb6b0589) importing the compiled pb2 modules with alias - [`3b8068a`](https://github.com/kokarare1212/librespot-python/commit/3b8068a67a64b1a80d8f258370ef97e32d2e1d6e) fixed class use insted of module ### 📊 Changes **51 files changed** (+87 additions, -91 deletions) <details> <summary>View changed files</summary> 📝 `librespot/Version.py` (+1 -1) 📝 `librespot/ZeroconfServer.py` (+1 -1) 📝 `librespot/audio/AudioKeyManager.py` (+2 -2) 📝 `librespot/audio/GeneralAudioStream.py` (+1 -1) 📝 `librespot/audio/PlayableContentFeeder.py` (+9 -9) 📝 `librespot/audio/StreamId.py` (+1 -1) 📝 `librespot/audio/__init__.py` (+8 -8) 📝 `librespot/audio/cdn/CdnFeedHelper.py` (+7 -7) 📝 `librespot/audio/cdn/CdnManager.py` (+5 -5) 📝 `librespot/audio/decoders/AudioQuality.py` (+1 -1) 📝 `librespot/audio/format/AudioQualityPicker.py` (+1 -1) 📝 `librespot/audio/format/SuperAudioFormat.py` (+1 -1) 📝 `librespot/audio/storage/ChannelManager.py` (+1 -1) 📝 `librespot/core/Session.py` (+15 -18) 📝 `librespot/dealer/ApiClient.py` (+2 -2) 📝 `librespot/mercury/MercuryClient.py` (+2 -2) 📝 `librespot/mercury/RawMercuryRequest.py` (+1 -1) 📝 `librespot/metadata/__init__.py` (+5 -5) 📝 `librespot/player/StateWrapper.py` (+5 -5) 📝 `librespot/player/codecs/VorbisOnlyAudioQuality.py` (+1 -1) _...and 31 more files_ </details> ### 📄 Description The below error was shown when using the package in Ubuntu 20.04 and _pb2 suffix was needed to fix the error for the compiled files and also there was an error in the proxy configuration in Session.py. ![image](https://user-images.githubusercontent.com/11836100/119645344-a7a7b300-be3d-11eb-9b22-f11a1d401565.png) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>