mirror of
https://github.com/devgianlu/librespot-android.git
synced 2026-04-25 21:35:49 +03:00
[GH-ISSUE #11] App gets stuck at player.waitReady() on Android 6 #9
Labels
No labels
bug
enhancement
enhancement
enhancement
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/librespot-android#9
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @devgianlu on GitHub (May 5, 2021).
Original GitHub issue: https://github.com/devgianlu/librespot-android/issues/11
It seems that the player gets stuck here:
github.com/devgianlu/librespot-android@3278d3db61/app/src/main/java/xyz/gianlu/librespot/android/MainActivity.java (L184)Internally librespot-java uses a
CompletableFuturewhich may not be supported on Android 6, even with desugaring.@funtax commented on GitHub (May 5, 2021):
Hmmm, this might be an endless game. But maybe it's simple to solve? As said, i don't know what's worth the effort and what not.
https://github.com/SgtSilvio/android-retrofix
@devgianlu commented on GitHub (May 5, 2021):
I could also write an hackish piece of code that checks if the player is ready in a loop, but I think your solution would be better because the same issue could appear in other parts of the code.
@mitschwimmer commented on GitHub (May 12, 2021):
I would rather shy away from using retrofix. It is too hacky for my taste. I have this nagging thought of "why is Google not backporting completeable futures and the likes?" -there might be subtleties not easy to get right. Android 7 support is already great from my point of view.
MediaCodecas decoder #23