[GH-ISSUE #8] Add Instrumented Tests for Sink #4

Closed
opened 2026-02-28 14:23:58 +03:00 by kerem · 3 comments
Owner

Originally created by @mitschwimmer on GitHub (Apr 25, 2021).
Original GitHub issue: https://github.com/devgianlu/librespot-android/issues/8

Originally assigned to: @mitschwimmer on GitHub.

Originally created by @mitschwimmer on GitHub (Apr 25, 2021). Original GitHub issue: https://github.com/devgianlu/librespot-android/issues/8 Originally assigned to: @mitschwimmer on GitHub.
kerem closed this issue 2026-02-28 14:23:58 +03:00
Author
Owner

@mitschwimmer commented on GitHub (Apr 25, 2021):

@devgianlu, would you be able to provide a method that is generating a stream of raw PCM data that I could use for testing?

So farI am only able to create a finite byte array that does lead to an audible tone if I use AudioTrack.MODE_STATIC in AndroidSinkOutput. The test in fd4c3a0 does pass with AudioTrack.MODE_STREAM as we actually need it, but then I do not get an actually audible tone during the test.

<!-- gh-comment-id:826381802 --> @mitschwimmer commented on GitHub (Apr 25, 2021): @devgianlu, would you be able to provide a method that is generating a stream of raw PCM data that I could use for testing? So farI am only able to create a finite byte array that does lead to an audible tone if I use AudioTrack.MODE_STATIC in AndroidSinkOutput. The test in fd4c3a0 does pass with AudioTrack.MODE_STREAM as we actually need it, but then I do not get an actually audible tone during the test.
Author
Owner

@mitschwimmer commented on GitHub (Apr 26, 2021):

Hey @devgianlu, nevermind. I found a viable solution.

<!-- gh-comment-id:827168362 --> @mitschwimmer commented on GitHub (Apr 26, 2021): Hey @devgianlu, nevermind. I found a viable solution.
Author
Owner

@devgianlu commented on GitHub (Apr 27, 2021):

Hey @devgianlu, nevermind. I found a viable solution.

Awesome! Hadn't time to have a look. Next thing on my schedule is the UI.

<!-- gh-comment-id:827339721 --> @devgianlu commented on GitHub (Apr 27, 2021): > Hey @devgianlu, nevermind. I found a viable solution. Awesome! Hadn't time to have a look. Next thing on my schedule is the UI.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librespot-android#4
No description provided.