[PR #2] [MERGED] Make Sink work #21

New issue

Closed

opened 2026-02-28 14:24:07 +03:00 by kerem · 0 comments

kerem commented

2026-02-28 14:24:07 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/devgianlu/librespot-android/pull/2
Author: @mitschwimmer
Created: 4/25/2021
Status: ✅ Merged
Merged: 4/25/2021
Merged by: @devgianlu

Base: master ← Head: get-sink-to-work

📝 Commits (3)

cf3a312 Make Sink work
d84e312 Merge branch 'master' into get-sink-to-work
7cd3697 Working with Tremolo decoder

📊 Changes

6 files changed (+128 additions, -16 deletions)

View changed files

📝 app/build.gradle (+3 -1)
📝 app/src/main/AndroidManifest.xml (+1 -0)
📝 app/src/main/java/xyz/gianlu/librespot/android/MainActivity.java (+39 -6)
📝 gradlew (+0 -0)
📝 librespot-android-decoder-tremolo/src/main/java/xyz/gianlu/librespot/player/codecs/tremolo/OggDecodingInputStream.java (+49 -0)
📝 librespot-android-sink/src/main/java/xyz/gianlu/librespot/android/sink/AndroidSinkOutput.java (+36 -9)

📄 Description

Hey @devgianlu, I finally found some time to make this work. I have a couple of questions and would like your review which is why I am not just merging this.
I will place my Implementation questions/remarks as comments on the PR.
Regarding testing, I want to transform the MainActivity of the app-module into a couple of emulator/device Integration Tests which will be expecting credentials as environment variables. Would you like to keep the app-module as an implementation example?

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/devgianlu/librespot-android/pull/2 **Author:** [@mitschwimmer](https://github.com/mitschwimmer) **Created:** 4/25/2021 **Status:** ✅ Merged **Merged:** 4/25/2021 **Merged by:** [@devgianlu](https://github.com/devgianlu) **Base:** `master` ← **Head:** `get-sink-to-work` --- ### 📝 Commits (3) - [`cf3a312`](https://github.com/devgianlu/librespot-android/commit/cf3a31200119efe96ede1293cb4e71b1e32c0396) Make Sink work - [`d84e312`](https://github.com/devgianlu/librespot-android/commit/d84e31213803745d808a9d77e31f46a43a9b231e) Merge branch 'master' into get-sink-to-work - [`7cd3697`](https://github.com/devgianlu/librespot-android/commit/7cd36974363b9668af5109b2da52617d1485e5d2) Working with Tremolo decoder ### 📊 Changes **6 files changed** (+128 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `app/build.gradle` (+3 -1) 📝 `app/src/main/AndroidManifest.xml` (+1 -0) 📝 `app/src/main/java/xyz/gianlu/librespot/android/MainActivity.java` (+39 -6) 📝 `gradlew` (+0 -0) 📝 `librespot-android-decoder-tremolo/src/main/java/xyz/gianlu/librespot/player/codecs/tremolo/OggDecodingInputStream.java` (+49 -0) 📝 `librespot-android-sink/src/main/java/xyz/gianlu/librespot/android/sink/AndroidSinkOutput.java` (+36 -9) </details> ### 📄 Description Hey @devgianlu, I finally found some time to make this work. I have a couple of questions and would like your review which is why I am not just merging this. I will place my Implementation questions/remarks as comments on the PR. Regarding testing, I want to transform the MainActivity of the app-module into a couple of emulator/device Integration Tests which will be expecting credentials as environment variables. Would you like to keep the app-module as an implementation example? --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>