[PR #269] [MERGED] refactor: Add Python type annotations wherever appropriate #350

New issue

Closed

opened 2026-03-02 12:40:48 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:40:48 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kavishdevar/librepods/pull/269
Author: @mikomikotaishi
Created: 11/18/2025
Status: ✅ Merged
Merged: 11/19/2025
Merged by: @kavishdevar

Base: main ← Head: main

📝 Commits (2)

28c6dce Add Python type annotations wherever appropriate
9c55463 Might as well annotate this too

📊 Changes

7 files changed (+680 additions, -699 deletions)

View changed files

➕ head-tracking/colors.py (+29 -0)
📝 head-tracking/connection_manager.py (+18 -16)
📝 head-tracking/gestures.py (+108 -131)
📝 head-tracking/head_orientation.py (+61 -80)
📝 head-tracking/plot.py (+274 -291)
📝 linux/hearing-aid-adjustments.py (+127 -125)
📝 proximity_keys.py (+63 -56)

📄 Description

This pull request:

Moves Colors and ColorFormatter to a separate file, rather than repeating it three times
Adds Python type annotations wherever/whenever appropriate
Organises import statements alphabetically, and adds from import statements wherever appropriate for name simplification
Replaces string concatenations with fstrings when possible
Replaces if/else with match

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kavishdevar/librepods/pull/269 **Author:** [@mikomikotaishi](https://github.com/mikomikotaishi) **Created:** 11/18/2025 **Status:** ✅ Merged **Merged:** 11/19/2025 **Merged by:** [@kavishdevar](https://github.com/kavishdevar) **Base:** `main` ← **Head:** `main` --- ### 📝 Commits (2) - [`28c6dce`](https://github.com/kavishdevar/librepods/commit/28c6dce292d092006c62d98fc3e91e64c9ac985f) Add Python type annotations wherever appropriate - [`9c55463`](https://github.com/kavishdevar/librepods/commit/9c55463e0d5d2fe67cf421d1007e530861fc2346) Might as well annotate this too ### 📊 Changes **7 files changed** (+680 additions, -699 deletions) <details> <summary>View changed files</summary> ➕ `head-tracking/colors.py` (+29 -0) 📝 `head-tracking/connection_manager.py` (+18 -16) 📝 `head-tracking/gestures.py` (+108 -131) 📝 `head-tracking/head_orientation.py` (+61 -80) 📝 `head-tracking/plot.py` (+274 -291) 📝 `linux/hearing-aid-adjustments.py` (+127 -125) 📝 `proximity_keys.py` (+63 -56) </details> ### 📄 Description This pull request: * Moves `Colors` and `ColorFormatter` to a separate file, rather than repeating it three times * Adds Python type annotations wherever/whenever appropriate * Organises `import` statements alphabetically, and adds `from import` statements wherever appropriate for name simplification * Replaces string concatenations with fstrings when possible * Replaces if/else with match --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>