[PR #222] [MERGED] linux: add support for multiple media players #335

Closed
opened 2026-03-02 12:40:43 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/kavishdevar/librepods/pull/222
Author: @kavishdevar
Created: 10/2/2025
Status: Merged
Merged: 10/2/2025
Merged by: @kavishdevar

Base: mainHead: linux/handle-multiple-audio-sources


📝 Commits (1)

  • b4cd740 linux: add support for multiple media players

📊 Changes

3 files changed (+112 additions, -51 deletions)

View changed files

📝 linux/media/mediacontroller.cpp (+95 -47)
📝 linux/media/mediacontroller.h (+2 -2)
📝 linux/media/pulseaudiocontroller.cpp (+15 -2)

📄 Description

fixes #207

note: this only works if the browser shows two instances for multiple media sources. playing two youtube videos in two separate tabs in Firefox exposed only one instance of media player which will not result in all media sources paused. Something I can't fix. But now, it will only resume the services it has paused not just the first one.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/kavishdevar/librepods/pull/222 **Author:** [@kavishdevar](https://github.com/kavishdevar) **Created:** 10/2/2025 **Status:** ✅ Merged **Merged:** 10/2/2025 **Merged by:** [@kavishdevar](https://github.com/kavishdevar) **Base:** `main` ← **Head:** `linux/handle-multiple-audio-sources` --- ### 📝 Commits (1) - [`b4cd740`](https://github.com/kavishdevar/librepods/commit/b4cd740f9b3e9f6d2b0ce0813e102088527a72e6) linux: add support for multiple media players ### 📊 Changes **3 files changed** (+112 additions, -51 deletions) <details> <summary>View changed files</summary> 📝 `linux/media/mediacontroller.cpp` (+95 -47) 📝 `linux/media/mediacontroller.h` (+2 -2) 📝 `linux/media/pulseaudiocontroller.cpp` (+15 -2) </details> ### 📄 Description fixes #207 note: this only works if the browser shows two instances for multiple media sources. playing two youtube videos in two separate tabs in Firefox exposed only one instance of media player which will not result in all media sources paused. Something I can't fix. But now, it will only resume the services it has paused not just the first one. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-02 12:40:43 +03:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/librepods#335
No description provided.