[PR #218] [CLOSED] fix android CI + rootmodule builder V2 #333

New issue

Closed

opened 2026-03-02 12:40:42 +03:00 by kerem · 0 comments

kerem commented

2026-03-02 12:40:42 +03:00

Owner

📋 Pull Request Information

Original PR: https://github.com/kavishdevar/librepods/pull/218
Author: @NL-TCH
Created: 10/1/2025
Status: ❌ Closed

Base: main ← Head: fix-root-module

📝 Commits (2)

83a4156 fix module install error
15379d9 improve testing of root module

📊 Changes

2 files changed (+27 additions, -21 deletions)

View changed files

📝 .github/workflows/ci-android.yml (+26 -20)
📝 build-magisk-module.sh (+1 -1)

📄 Description

fixes #216

So a few noteworthy things in this PR:

Fix #216 by changing the output of curl in the root-module-builder
Build the root-module on every PR/commit for easier testing
Publish the root-module as an artifact on every PR/commit for easier testing
set-output is deprecated, and changed to GITHUB_OUTPUT

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/kavishdevar/librepods/pull/218 **Author:** [@NL-TCH](https://github.com/NL-TCH) **Created:** 10/1/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-root-module` --- ### 📝 Commits (2) - [`83a4156`](https://github.com/kavishdevar/librepods/commit/83a41561678745cdc955f0ceca0e43511830672b) fix module install error - [`15379d9`](https://github.com/kavishdevar/librepods/commit/15379d963d72ff11260e471da28db73f9556d49c) improve testing of root module ### 📊 Changes **2 files changed** (+27 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/ci-android.yml` (+26 -20) 📝 `build-magisk-module.sh` (+1 -1) </details> ### 📄 Description fixes #216 So a few noteworthy things in this PR: - Fix #216 by changing the output of curl in the root-module-builder - Build the root-module on every PR/commit for easier testing - Publish the root-module as an artifact on every PR/commit for easier testing - `set-output` is deprecated, and changed to `GITHUB_OUTPUT` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>