[PR #2] [MERGED] Fix for handling single line config files, connected with line ending… #4

Closed
opened 2026-03-04 03:27:50 +03:00 by kerem · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/zeropingheroes/lancache-dns-unbound/pull/2
Author: @ff-ahumberston
Created: 3/22/2019
Status: Merged
Merged: 4/28/2019
Merged by: @ilumos

Base: masterHead: master


📝 Commits (2)

  • b3f37e0 Fix for handling single line config files, connected with line endings being handled by while
  • dc1e23b Update generate.sh

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 generate.sh (+1 -1)

📄 Description

It was observed that when attempting to process single line configs, for example hirez.txt, the script would not create local-data entry correctly. The section would be commented, but there would be no entry written by the while loop.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/zeropingheroes/lancache-dns-unbound/pull/2 **Author:** [@ff-ahumberston](https://github.com/ff-ahumberston) **Created:** 3/22/2019 **Status:** ✅ Merged **Merged:** 4/28/2019 **Merged by:** [@ilumos](https://github.com/ilumos) **Base:** `master` ← **Head:** `master` --- ### 📝 Commits (2) - [`b3f37e0`](https://github.com/zeropingheroes/lancache-dns-unbound/commit/b3f37e00fb6c8da16c3a023b4819f4a14e360a81) Fix for handling single line config files, connected with line endings being handled by while - [`dc1e23b`](https://github.com/zeropingheroes/lancache-dns-unbound/commit/dc1e23b50ff2ddc98ed3ad5926ec8b34216e0caf) Update generate.sh ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `generate.sh` (+1 -1) </details> ### 📄 Description It was observed that when attempting to process single line configs, for example hirez.txt, the script would not create local-data entry correctly. The section would be commented, but there would be no entry written by the while loop. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
kerem 2026-03-04 03:27:50 +03:00
Sign in to join this conversation.
No labels
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/lancache-dns-unbound#4
No description provided.