mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #1711] FR: Multithreaded library synchronization #937
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#937
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @maevii on GitHub (Sep 30, 2023).
Original GitHub issue: https://github.com/koel/koel/issues/1711
Description
At the moment,
php artisan koel:syncuses a simple foreach loop to iterate through all songs and add them to the database, occasionally stopping to update the progress bar. This can take quite a long time on large libraries no matter the hardware involved (my 50k FLAC song library takes upwards of 40 minutes to scan for the first time with a 7950X3D, even when stored on a Samsung 980 PRO withmemory_limitset to 8192M). I think this could be improved if the work was split up into multiple threads that run simultaneously.Making 1 thread per song would probably be excessive for large libraries, and since the CPU usage while scanning is very low I don't think 1 thread per CPU core would make much sense either, though that can only really be verified by testing.
Example
N/A
@phanan commented on GitHub (Dec 28, 2023):
PR welcomed.