mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #132] Add AAC (.m4a) support #92
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#92
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jacopo-j on GitHub (Dec 21, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/132
I think AAC music is quite popular nowadays, it has a better quality than MP3; most of my music library is in that format. Its support would be a nice enhancement.
@phanan commented on GitHub (Dec 22, 2015):
This is still in plan.
@phanan commented on GitHub (Dec 22, 2015):
Added in the latest commit. Still experimental though, since I don't use AAC myself.
@jacopo-j commented on GitHub (Dec 22, 2015):
AAC files are detected but they do not play (it stucks on the indefinite progress bar). (Should I open a new issue?)
@phanan commented on GitHub (Jan 2, 2016):
Pls check http://caniuse.com/#feat=aac.
@jacopo-j commented on GitHub (Jan 4, 2016):
@phanan I can confirm the issue: AAC files do not play. Tested on Safari (OS X) and Safari (iOS) which both support AAC natively.
@phanan commented on GitHub (Jan 4, 2016):
Odd... Tried several files (I don't have many of them anyway), all work fine for me.
@jacopo-j commented on GitHub (Jan 5, 2016):
@phanan I tested many different AAC files, including some ones purchased on iTunes (DRM free). Most of them do not play, but others do, and I have no idea why (it doesn't seem related to the length of the song, origin of the file, etc).
I would share some of my files for you to do further testing, but they're copyrighted and I don't think I can do that.
By the way, AAC tags do not seem to be detected for any song.
@n0doubt commented on GitHub (Feb 4, 2016):
I too am having issues with AAC files, they are being detected in some cases and not playing correctly, however some are not even being detected (my library is more or less mostly AAC format).
@jacopo-j commented on GitHub (Feb 4, 2016):
@phanan I think this issue should be re-opened.
@phanan commented on GitHub (Feb 4, 2016):
My guess is, your server doesn't support AAC decoding. Can you check?
@jacopo-j commented on GitHub (Feb 4, 2016):
In that case AAC files would not play at all, would they?
@phanan commented on GitHub (Feb 4, 2016):
Well… like I said, I tried converting my songs into AAC, and they all worked fine. What's the error in the console?
@n0doubt commented on GitHub (Feb 4, 2016):
Forgive my lack of knowledge, but does the application rely on dependencies to decode AAC or is it done internally? If it relies on something else I can attempt to install and configure that but if otherwise, I can attempt to log the scanning and playback process in a development environment. Additionally, I was not able to extract any useful info from the console due to the way my setup is.
I think also there might be some sort of difference between AAC files downloaded direct from iTunes and files converted to AAC, I'll attempt to do some research.
@phanan commented on GitHub (Feb 4, 2016):
@jaggions made a very good point that if your server lacks of the necessary decoder, then no files should be able to play at all. Since in your case, some play and some don't, I'm now more curious about the errors in your browser's console.
@jacopo-j commented on GitHub (Feb 4, 2016):
I get no errors at all in my browser's console.
@n0doubt commented on GitHub (Feb 4, 2016):
Nothing unusual here
@phanan commented on GitHub (Feb 5, 2016):
I don't think that it's a browser...
On Fri, Feb 5, 2016 at 5:25 AM, n0doubt notifications@github.com wrote:
@phanan commented on GitHub (Feb 5, 2016):
The test is quite simple I think. If you can, just create a simple html
page with an audio tag, and point its source to the non-working aac file –
assuming that it's somewhere public – and see if it plays. That's how Koel
streams the music behind the scene actually.
On Fri, Feb 5, 2016 at 9:55 AM, An Phan me@phanan.net wrote:
@jacopo-j commented on GitHub (Feb 5, 2016):
@phanan I tried that, It did not work; files didn't play. I should point out that all the files I'm trying are .m4a files, not "pure" .aac.
@phanan commented on GitHub (Feb 6, 2016):
Then it's not a Koel issue, but your server's issue. I suggest Googling starting with "aac decoding" or something.
@cat24max commented on GitHub (Dec 30, 2022):
This is definitely still broken. M4A AAC files work on Chrome Desktop, but not on iOS.