mirror of
https://github.com/koel/koel.git
synced 2026-04-26 17:25:59 +03:00
[GH-ISSUE #1491] FLAC Tags (Vorbis Tags / Comments) are not registered. #854
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#854
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @jojoxd on GitHub (Aug 31, 2022).
Original GitHub issue: https://github.com/koel/koel/issues/1491
Describe the bug
Just as the title says, Vorbis tags are not imported into the database.
To reproduce
Steps to reproduce the behavior:
artisan koel:syncExpected behavior
I Expect flac files to be correctly imported using
artisan koel:syncScreenshots


Environment
Additional context
I've noticed this line, which is slightly different from how getID3's basic demo does it:
github.com/koel/koel@ddd2dff65d/app/Services/FileSynchronizer.php (L51)I think this would work great if we could use getID3's
CopyTagsToComments($data)function here, and only read from$data['comments']after that infromGetId3Info@phanan commented on GitHub (Sep 23, 2022):
Fixed and released in v6.2.0.