mirror of
https://github.com/koel/koel.git
synced 2026-04-26 01:06:00 +03:00
[GH-ISSUE #1333] Albums are sorted by artist not by album_artist #767
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#767
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @LeducH on GitHub (Jul 9, 2021).
Original GitHub issue: https://github.com/koel/koel/issues/1333
Describe the bug
Albums are sorted by artist not by album_artist
To reproduce
Steps to reproduce the behavior:
album1with different artist e.g. a original soundtrack. Make sure the album artist is set the same such asvarious artistand it has different artist for each track.artist 1, artist 2,...Expected behavior
The
album1is added as one with album artistvarious artistactual behavior
there is for each artist one entry
Environment
@heavydetail commented on GitHub (Aug 3, 2021):
having the same problem with some albums being split into a bunch of individual albums with just one track/artist.
@masterT commented on GitHub (Sep 22, 2021):
I think this has something to do with the
tagsargument provided to thekoel:synccommand (see app/Console/Commands/SyncCommand.php).The list of applicable tags are defined in:
github.com/koel/koel@4181b51192/app/Services/MediaSyncService.php (L25-L36)When no
tagsare specified it will use all those tags and pass them to the app/Services/FileSynchronizer.php to synchronize each file of the library.The song's album is considered a "compilation" if the meta
part_of_a_compilationis set or if the metaalbumartistis set and different from the metaartist:github.com/koel/koel@4181b51192/app/Services/FileSynchronizer.php (L125)github.com/koel/koel@4181b51192/app/Services/FileSynchronizer.php (L338-L345)@masterT commented on GitHub (Sep 22, 2021):
I use beets to manage my music library and fix metadata.
Here is an example of a song's metadata (using
exiftool):For this song, I would like Koel to create only one album for the artist "The Black Keys" (using the meta
albumartist), but also create the artist "The Black Keys feat. Prins Thomas" (using the metaartist) and see the album and song in which appeared in.Maybe the Koel model should allow referencing multiple artists (meta
artistandalbumartist). I don't know the scope of those changes.I would like to hear what the development team thinks of this, I would be happy to help.
@tomdoo commented on GitHub (Nov 1, 2021):
Hi
+1 🙂
@YamashitaRen commented on GitHub (Dec 25, 2021):
There has been a lot of talk about it but unfortunately, the dev does not seem to care much about the issue...
https://github.com/koel/koel/issues/980
@Archpanda commented on GitHub (Jan 29, 2022):
I proposed a simple PR, please review it and tell me if I'm totally wrong :p
@warpdesign commented on GitHub (Feb 7, 2022):
Thanks for your PR @Archpanda
I tried to fetch it and then ran
php artisan koel:syncbut it did not fix the problems I had with compilations/various artists that are mentionned in this issue: should I reimport all my songs?@Archpanda commented on GitHub (Feb 7, 2022):
Hi, thanks for your feedback, it's not cool if my PR doesn't work. I'll check again.
7 févr. 2022 12:34:07 Nicolas Ramz @.***>:
@warpdesign commented on GitHub (Feb 7, 2022):
Note that I had to rename
albumartisttoalbum_artistsince this is what the tag is named in my collection:=>
Maybe there was some other change involved? My PHP knowledge is rusty to say the least :)
@warpdesign commented on GitHub (Feb 9, 2022):
Actually this is normal after looking at the sync code: the tags are not parsed again if the file hasn't been modified. You have to use the
--forceoption so that the mp3 tags are parsed again.After using
php artisan koel:sync --forcetags are updated, but then I got a crash:@warpdesign commented on GitHub (Feb 9, 2022):
It crashes because $artist is not an object:
@phanan commented on GitHub (Jun 26, 2022):
Replaced by #1461.