starred/koel-koel
1
0
Fork 0
mirror of https://github.com/koel/koel.git synced 2026-04-25 16:56:02 +03:00
Code Issues 67 Projects Releases 10 Packages Wiki Activity

[GH-ISSUE #1299] Trying to access webui with invalid api-token causes error #749

New issue
Closed
opened 2026-02-26 02:34:09 +03:00 by kerem · 1 comment
kerem commented 2026-02-26 02:34:09 +03:00
Owner
Copy link

Originally created by @vitoyucepi on GitHub (Mar 30, 2021).
Original GitHub issue: https://github.com/koel/koel/issues/1299

Describe the bug
If I try to open app web ui page with invalid api-token, then this will cause error in server log.
User will be redirected to the login page(this is ok).

To reproduce
Steps to reproduce the behavior:

  1. Install and init application.
  2. Go to main page.
  3. Login.
  4. Open dev tools and intentionally break api-token.
    It's simply a shortcut.
  5. Reload page.
  6. Get an error in web server logs.

Environment

  • Koel version: 5.0.2
  • OS: docker(php:7.4.16-apache) on archlinux
  • Browser: Chrome 89
  • PHP version: 7.4.16
  • Node version: N/A

Additional context

web_1      | [2021-03-30 08:23:15] production.ERROR: Argument 10 passed to App\Http\Controllers\API\DataController::__construct() must implement interface Illuminate\Contracts\Auth\Authenticatable, null given {"exception":"[object] (TypeError(code: 0): Argument 10 passed to App\\Http\\Controllers\\API\\DataController::__construct() must implement interface Illuminate\\Contracts\\Auth\\Authenticatable, null given at /var/www/html/app/Http/Controllers/API/DataController.php:34)
web_1      | [stacktrace]
web_1      | #0 [internal function]: App\\Http\\Controllers\\API\\DataController->__construct()
web_1      | #1 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(870): ReflectionClass->newInstanceArgs()
web_1      | #2 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(712): Illuminate\\Container\\Container->build()
web_1      | #3 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(796): Illuminate\\Container\\Container->resolve()
web_1      | #4 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(651): Illuminate\\Foundation\\Application->resolve()
web_1      | #5 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(781): Illuminate\\Container\\Container->make()
web_1      | #6 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(268): Illuminate\\Foundation\\Application->make()
web_1      | #7 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(989): Illuminate\\Routing\\Route->getController()
web_1      | #8 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(950): Illuminate\\Routing\\Route->controllerMiddleware()
web_1      | #9 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(709): Illuminate\\Routing\\Route->gatherMiddleware()
web_1      | #10 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(685): Illuminate\\Routing\\Router->gatherRouteMiddleware()
web_1      | #11 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(669): Illuminate\\Routing\\Router->runRouteWithinStack()
web_1      | #12 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(635): Illuminate\\Routing\\Router->runRoute()
web_1      | #13 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(624): Illuminate\\Routing\\Router->dispatchToRoute()
web_1      | #14 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(166): Illuminate\\Routing\\Router->dispatch()
web_1      | #15 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}()
web_1      | #16 /var/www/html/app/Http/Middleware/ForceHttps.php(26): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #17 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): App\\Http\\Middleware\\ForceHttps->handle()
web_1      | #18 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #19 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
web_1      | #20 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #21 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle()
web_1      | #22 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #23 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle()
web_1      | #24 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #25 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle()
web_1      | #26 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}()
web_1      | #27 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(141): Illuminate\\Pipeline\\Pipeline->then()
web_1      | #28 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(110): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter()
web_1      | #29 /var/www/html/public/index.php(57): Illuminate\\Foundation\\Http\\Kernel->handle()
web_1      | #30 {main}
web_1      | "} 
web_1      | 192.168.32.1 - - [30/Mar/2021:08:23:15 +0000] "GET /api/data HTTP/1.1" 500 436 "http://localhost:8080/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Safari/537.36"
Originally created by @vitoyucepi on GitHub (Mar 30, 2021). Original GitHub issue: https://github.com/koel/koel/issues/1299 **Describe the bug** If I try to open app web ui page with invalid `api-token`, then this will cause error in server log. User will be redirected to the login page(this is ok). **To reproduce** Steps to reproduce the behavior: 1. Install and init application. 2. Go to main page. 3. Login. 4. Open dev tools and intentionally break `api-token`. It's simply a shortcut. 5. Reload page. 6. Get an error in web server logs. **Environment** - Koel version: 5.0.2 - OS: docker(php:7.4.16-apache) on archlinux - Browser: Chrome 89 - PHP version: 7.4.16 - Node version: N/A **Additional context** ``` web_1 | [2021-03-30 08:23:15] production.ERROR: Argument 10 passed to App\Http\Controllers\API\DataController::__construct() must implement interface Illuminate\Contracts\Auth\Authenticatable, null given {"exception":"[object] (TypeError(code: 0): Argument 10 passed to App\\Http\\Controllers\\API\\DataController::__construct() must implement interface Illuminate\\Contracts\\Auth\\Authenticatable, null given at /var/www/html/app/Http/Controllers/API/DataController.php:34) web_1 | [stacktrace] web_1 | #0 [internal function]: App\\Http\\Controllers\\API\\DataController->__construct() web_1 | #1 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(870): ReflectionClass->newInstanceArgs() web_1 | #2 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(712): Illuminate\\Container\\Container->build() web_1 | #3 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(796): Illuminate\\Container\\Container->resolve() web_1 | #4 /var/www/html/vendor/laravel/framework/src/Illuminate/Container/Container.php(651): Illuminate\\Foundation\\Application->resolve() web_1 | #5 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Application.php(781): Illuminate\\Container\\Container->make() web_1 | #6 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(268): Illuminate\\Foundation\\Application->make() web_1 | #7 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(989): Illuminate\\Routing\\Route->getController() web_1 | #8 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Route.php(950): Illuminate\\Routing\\Route->controllerMiddleware() web_1 | #9 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(709): Illuminate\\Routing\\Route->gatherMiddleware() web_1 | #10 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(685): Illuminate\\Routing\\Router->gatherRouteMiddleware() web_1 | #11 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(669): Illuminate\\Routing\\Router->runRouteWithinStack() web_1 | #12 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(635): Illuminate\\Routing\\Router->runRoute() web_1 | #13 /var/www/html/vendor/laravel/framework/src/Illuminate/Routing/Router.php(624): Illuminate\\Routing\\Router->dispatchToRoute() web_1 | #14 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(166): Illuminate\\Routing\\Router->dispatch() web_1 | #15 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(128): Illuminate\\Foundation\\Http\\Kernel->Illuminate\\Foundation\\Http\\{closure}() web_1 | #16 /var/www/html/app/Http/Middleware/ForceHttps.php(26): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #17 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): App\\Http\\Middleware\\ForceHttps->handle() web_1 | #18 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #19 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle() web_1 | #20 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/TransformsRequest.php(21): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #21 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\TransformsRequest->handle() web_1 | #22 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/ValidatePostSize.php(27): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #23 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\ValidatePostSize->handle() web_1 | #24 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Middleware/PreventRequestsDuringMaintenance.php(86): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #25 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(167): Illuminate\\Foundation\\Http\\Middleware\\PreventRequestsDuringMaintenance->handle() web_1 | #26 /var/www/html/vendor/laravel/framework/src/Illuminate/Pipeline/Pipeline.php(103): Illuminate\\Pipeline\\Pipeline->Illuminate\\Pipeline\\{closure}() web_1 | #27 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(141): Illuminate\\Pipeline\\Pipeline->then() web_1 | #28 /var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Http/Kernel.php(110): Illuminate\\Foundation\\Http\\Kernel->sendRequestThroughRouter() web_1 | #29 /var/www/html/public/index.php(57): Illuminate\\Foundation\\Http\\Kernel->handle() web_1 | #30 {main} web_1 | "} web_1 | 192.168.32.1 - - [30/Mar/2021:08:23:15 +0000] "GET /api/data HTTP/1.1" 500 436 "http://localhost:8080/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/89.0.4389.105 Safari/537.36" ```
kerem closed this issue 2026-02-26 02:34:09 +03:00
kerem commented 2026-02-26 02:34:10 +03:00
Author
Owner
Copy link

@phanan commented on GitHub (Apr 11, 2021):

I don't see how that's a bug. You have an invalid token.

<!-- gh-comment-id:817347801 --> @phanan commented on GitHub (Apr 11, 2021): I don't see how that's a bug. You have an invalid token.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
master
dependabot/composer/phpunit/phpunit-12.5.22
dependabot/npm_and_yarn/dompurify-3.4.0
dependabot/npm_and_yarn/vite-plus-0.1.17
dependabot/composer/phpseclib/phpseclib-3.0.51
release
1889-duplicate-upload-detection
test/home-screen-empty-to-content
fix/exclude-songless-albums-from-recently-added
refactor/laravel-prompts
fix/wma-cover-art-exception
fix/remove-redundant-seed-step
chore/upgrade-laravel-13
chore/upgrade-vue-3.5.29
test/phase-7-components
dbg-2142
demo-fix
debug-mysql
trusthosts
seek
fix-equalizer
sentry
invite-user
remove-v6-obsolete
fix/song-list
feat/paths-filter
fix/home
fix/footer
feat/progressive
php81
dev/public-playlists
cy
feat/l7
dependabot/composer/pusher/pusher-php-server-4.1.4
dependabot/composer/laravel/framework-5.8.38
dependabot/composer/jackiedo/dotenv-editor-1.1.1
renovate/pin-dependencies
actions
api-doc
feat/recently-played
fix-tests
fix-cover-page
upload
stylejs-196
compilation
vuex
android-notif
nojquery
demo
vue2
2.0
1.1
v9.1.1
latest
v9.1.0
v9.0.0
v8.3.1
v8.3.0
v8.2.0
v8.1.0
v8.0.0
v7.15.1
v7.15.0
v7.14.0
v7.13.0
v7.12.0
v7.11.0
v7.10.4
v7.10.3
v7.10.2
v7.10.1
v7.10.0
v7.9.0
v7.8.1
v7.8.0
v7.7.1
v7.7.0
v7.6.3
v7.6.2
v7.6.1
v7.6.0
v7.5.2
v7.5.1
v7.5.0
v7.4.2
v7.4.1
v7.4.0
v7.3.1
v7.3.0
v7.2.2
v7.2.1
v7.2.0
v7.1.0
v7.0.12
v7.0.11
v7.0.10
v7.0.9
v7.0.8
v7.0.7
v7.0.6
v7.0.5
v7.0.4
v7.0.3
v7.0.2
v7.0.1
v7.0.0
v6.12.1
v6.12.0
v6.11.5
v6.11.4
v6.11.3
v6.11.2
v6.11.1
v6.11.0
v6.10.0
v6.9.0
v6.8.5
v6.8.4
v6.8.3
v6.8.2
v6.8.1
v6.8.0
v6.7.5
v6.7.4
v6.7.3
v6.7.2
v6.7.1
v6.7.0
v6.6.0
v6.5.3
v6.5.2
v6.5.1
v6.5.0
v6.4.3
v6.4.2
v6.4.1
v6.4.0
v6.3.0
v6.2.2
v6.2.1
v6.2.0
v6.1.0
v6.0.6
v6.0.5
v6.0.4
v6.0.3
v6.0.2
v6.0.1
v6.0.0
v0.0.0-beta
v5.1.14
v5.1.13
v5.1.12
v5.1.11
v5.1.10
v5.1.9
v5.1.8
v5.1.7
v5.1.6
v5.1.5
v5.1.4
v5.1.3
v5.1.2
v5.1.1
v5.1.0
v5.0.2
v5.0.1
v5.0.0
v4.4.0
v4.3.1
v4.3.0
v4.2.2
v4.2.1
v4.2.0
v4.1.1
v4.1.0
v4.0.0
v3.7.2
v3.7.1
v3.7.0
v3.6.2
v3.6.1
v3.6.0
v3.5.5
v3.5.4
v3.5.3
v3.5.2
v3.5.1
v3.5.0
v3.4.1
v3.4.0
v3.3.1
v3.3.0
v3.2.0
v3.1.1
v3.1.0
v3.0.1
v3.0.0
v2.2.1
v2.2.0
v2.1.0
v2.0.2
v2.0.1
v2.0.0
v1.1.2
v1.1.1
1.0.0-beta
Labels
Clear labels   
Authentication

   
Dependencies

   
Documentation

   
Feature Request

   
Flac

   
Help Wanted

   
Installation/Setup

   
Integration

   
Mobile

   
PR Welcome

   
Pending Release

   
Performance

   
Playlist

   
S3

   
Search

   
Sync

   
[Pri] Low

   
[Pri] Normal

   
[Status] Keep Open

   
[Status] Needs Author Reply

   
[Status] Needs Review

   
[Status] Stale

   
[Status] Will Implement

   
[Type] Blessed

   
[Type] Bug

   
[Type] Duplicate

   
[Type] Enhancement

   
[Type] Help Request

   
[Type] Question

   
[Type] Task

   
pull-request

Mirrored from GitHub Pull Request

No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#749
No description provided.