mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #1282] Player bar hiden by Safari's interface #735
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#735
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @FrostyPinkPlume on GitHub (Feb 20, 2021).
Original GitHub issue: https://github.com/koel/koel/issues/1282
Describe the bug
When using Koel with Safari with an Iphone (in my case, an Iphone X R), the Safari's lowest interface hide the player bar.
To reproduce
Steps to reproduce the behavior:
Expected behavior
Using the player bar to pause or change music.
Environment
Thank you for this great project, it's awesome !
@FrostyPinkPlume commented on GitHub (Feb 20, 2021):
It seems like something like this would help :
``
But I don't have the slightest idea were to add this in the project
@phanan commented on GitHub (Apr 11, 2021):
Thanks for the report. I can't reproduce this bug though (and I'm using an iPhone myself). Can you check with the latest version?
@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
Sadly, this is not my phone that has that problem, however it appear that this issue also visible using latest verson of firefox for android, even when having the toolbar on the top.
@phanan commented on GitHub (Apr 13, 2021):
Please include a screenshot then. I can't really imagine what happens.
@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
When using a chromium based browser (Brave browser in my case), for android, I can bypass this issue by scrolling down the topbar). This, however don't work using firefox for Android.
I'm asking for a screenshot for Safari with the version.
@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
Update : Now using 5.1.0
@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
And this is the same issur using safari with ios 14.4.2.
@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
Maybe this could be kinda bypassed by having something like
<meta name="apple-mobile-web-app-capable" content="yes" />and
<meta name="viewport" content="width=device-width, initial-scale=1.0, maximum-scale=1.0, user-scalable=no" />That must resolve the problem by having the interface totally removed using a home-screen link, however, only using IOS.
I heard Safari can use it though....
However, chrome has
<meta name="mobile-web-app-capable" content="yes">@phanan commented on GitHub (Apr 13, 2021):
Interesting. Indeed, I've been using Edge on iPhone with the assumption that it uses the same Webkit engine as mobile Safari, and this problem doesn't appear.
If you've verified that adding
mobile-web-app-capableandapple-mobile-web-app-capablemeta works, please open a PR. The tags can be added here: https://github.com/koel/koel/blob/master/resources/views/index.blade.php. Edit: They're already there apparently.@FrostyPinkPlume commented on GitHub (Apr 13, 2021):
I'll try when at home.
Edit :
True, there is
mobile-web-app-capableUsing :
apple-mobile-web-app-capableis missing@phanan commented on GitHub (May 7, 2021):
Sorry for the late response. So does
apple-mobile-web-app-capablefix the problem? If it does, can you create a PR?@phanan commented on GitHub (Oct 18, 2022):
This shouldn't be a problem anymore.