mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #1283] Error due to front-end build in koel:init #734
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#734
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @Hyzual on GitHub (Feb 21, 2021).
Original GitHub issue: https://github.com/koel/koel/issues/1283
Describe the bug
Hi, first of all I wanted to thank all contributors for v5.0.2 which is much easier to install now that ready-to-install zip file and tarball are built and delivered in the Release 😄. As maintainer of a docker image for Koel, it makes my life much easier.
There is however a minor annoyance left: when you run
php artisan koel:init, it still tries to rebuild the front-end Javascript app and assets. I believe that now that there is a dedicated github Action to build and release those assets, this step appears to no longer be necessary inkoel:init. Whenyarnis not installed on the system (it is the case in the Docker image I'm maintaining), runningkoel:initwill produce the following error despite the fact that front-end assets are already present and installed.The error:
To reproduce
Using docker:
<koel_password>in the file by a passworddocker-compose up -f docker-compose.yml -d(Assuming the downloaded file is nameddocker-compose.yml)koel_container_namein the following command by the container's name and run it:docker exec -it koel_container_name php artisan koel:initWithout using docker:
yarninstalledphp artisan koel:initExpected behavior
I would expect the "Now to front-end stuff" step to be omitted, since front-end assets are already built and optimized by Github Actions.
Screenshots
Not sure screenshots would help here, I can include some upon request.
Environment
Additional context
No additional context.
Thanks !
@Hyzual commented on GitHub (Feb 21, 2021):
While looking quickly in files I discover that there is a "no-assets" option which allows to skip that step. I did not know it existed, I'll try it.
Edit: it works well and does the job. I'll document the option for people using the docker image.
@phanan commented on GitHub (Mar 25, 2021):
You're right, that option is exactly for the case.
@phanan commented on GitHub (Mar 26, 2021):
Btw @Hyzual can you check your Twitter DM?
@Brancliff commented on GitHub (Mar 9, 2024):
Just a heads up, it seems that this is still the case, even after the switch from hyzual/koel to phanan/koel. --no-assets fixed it for me as well