mirror of
https://github.com/koel/koel.git
synced 2026-04-25 00:36:03 +03:00
[GH-ISSUE #1256] Searching breaks lazy-load pagination #718
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#718
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @CirnoT on GitHub (Nov 10, 2020).
Original GitHub issue: https://github.com/koel/koel/issues/1256
Describe the bug
On a big library (160k tracks), searching for an album and then clearing search parameters results in full library being rendered without pagination, consuming good 2GB of memory and eating CPU like crazy (for Chromium at least).
To reproduce
Expected behavior
Pagination is still applied.
Environment
e9b850fc33)Additional context
This might not happen instantly, I generally had better results triggering this when typing in search bar and CTRL+X the content of it.
@BrookeDot commented on GitHub (Dec 30, 2020):
Related, #1219. A dedicated search page/search API may just naturally resolve this but let's keep it open for now.
@phanan commented on GitHub (Dec 30, 2020):
Indeed, and the feature has landed on
masterseveral days ago. Please don't just upgrade though, asmastercontains some major breaking changes, most significantly the directory structure 😄