[GH-ISSUE #1256] Searching breaks lazy-load pagination #718

Closed
opened 2026-02-26 02:34:04 +03:00 by kerem · 2 comments
Owner

Originally created by @CirnoT on GitHub (Nov 10, 2020).
Original GitHub issue: https://github.com/koel/koel/issues/1256

Describe the bug
On a big library (160k tracks), searching for an album and then clearing search parameters results in full library being rendered without pagination, consuming good 2GB of memory and eating CPU like crazy (for Chromium at least).

To reproduce

  1. Search for something
  2. Clear search parameters

Expected behavior
Pagination is still applied.

Environment

  • Koel version [e.g. v4.1.0]: master (e9b850fc33)
  • OS: [e.g. macOS Mojave] Debian 10
  • Browser [e.g. Chrome 79] Chromium 86
  • PHP version [e.g. v7.2.0]: v7.3 from Debian repository
  • Node version [e.g. v10.15.3]: v14.15.0 (current LTS)

Additional context
This might not happen instantly, I generally had better results triggering this when typing in search bar and CTRL+X the content of it.

Originally created by @CirnoT on GitHub (Nov 10, 2020). Original GitHub issue: https://github.com/koel/koel/issues/1256 **Describe the bug** On a big library (160k tracks), searching for an album and then clearing search parameters results in full library being rendered without pagination, consuming good 2GB of memory and eating CPU like crazy (for Chromium at least). **To reproduce** 1. Search for something 2. Clear search parameters **Expected behavior** Pagination is still applied. **Environment** - Koel version [e.g. v4.1.0]: master (e9b850fc3346b204b9b95e1e99d9a8752f3c6530) - OS: [e.g. macOS Mojave] Debian 10 - Browser [e.g. Chrome 79] Chromium 86 - PHP version [e.g. v7.2.0]: v7.3 from Debian repository - Node version [e.g. v10.15.3]: v14.15.0 (current LTS) **Additional context** This might not happen instantly, I generally had better results triggering this when typing in search bar and CTRL+X the content of it.
Author
Owner

@BrookeDot commented on GitHub (Dec 30, 2020):

Related, #1219. A dedicated search page/search API may just naturally resolve this but let's keep it open for now.

<!-- gh-comment-id:752337946 --> @BrookeDot commented on GitHub (Dec 30, 2020): Related, #1219. A dedicated search page/search API may just naturally resolve this but let's keep it open for now.
Author
Owner

@phanan commented on GitHub (Dec 30, 2020):

Indeed, and the feature has landed on master several days ago. Please don't just upgrade though, as master contains some major breaking changes, most significantly the directory structure 😄

<!-- gh-comment-id:752792757 --> @phanan commented on GitHub (Dec 30, 2020): Indeed, and the feature has landed on `master` several days ago. Please don't just upgrade though, as `master` contains some major breaking changes, most significantly the directory structure 😄
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#718
No description provided.