mirror of
https://github.com/koel/koel.git
synced 2026-04-26 17:25:59 +03:00
[GH-ISSUE #1179] Support ffmpeg audio filters #676
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#676
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @JD557 on GitHub (Feb 8, 2020).
Original GitHub issue: https://github.com/koel/koel/issues/1179
Description
Since there's already a transcoding streamer that uses ffmpeg (https://github.com/phanan/koel/blob/master/app/Services/Streamers/TranscodingStreamer.php).
I think it should be pretty simple and helpful to add some optional ffmpeg filters, such as:
(I haven't tested those flags, so I'm not sure if they are suitable for streaming)
I think that (at least for a first version), it would be enough to add this as a
config/koel.php.I would send a PR for this, but I'm not sure if the
TranscodingStreameris always used (I'm pretty sure its not, since I had koel working for a while with a misconfigured ffmpeg).This feature would have to force the
TranscodingStreamerto always be used, and I'm not familiar with the codebase to know where those checks are performed.@phanan commented on GitHub (Feb 11, 2020):
Thanks for the idea.
TranscodingStreameris and should be only used for audios that require transcoding. While filters can be good for some, I doubt they are the norms and should determine the usage of the streamer. Not to mention, enforcingTranscodingStreamer, at least for now, would break some existing functionalities e.g. fast-forwarding and client caching.