mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #98] Last.fm scrobbling support #67
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#67
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ronilaukkarinen on GitHub (Dec 17, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/98
Personally I don't listen music without scrobbling, so why don't you add Last.fm support? That would be awesome!
@etopian commented on GitHub (Dec 17, 2015):
before doing that, how about adding a scrobbling function to the app itself. it would be nice to have a history of everything you have been listening to in the app itself as well.
@ronilaukkarinen commented on GitHub (Dec 17, 2015):
Yeah, with Last.fm there's a lot of possibilities, like in musiccabinet it's used with syncing the favorites with loved tracks, fetching missing cover art, artist info, etc.
But scrobbling support is a start.
Personally not that good at with laravel/vue/js so not eligible for making a pull request.
@phanan commented on GitHub (Dec 17, 2015):
Sounds like great ideas. Will definitely look into these, even though I don't use scrobbling at all.
@ronilaukkarinen commented on GitHub (Dec 17, 2015):
To defend the idea; many users still scrobble, personally been scrobbling over 10 years now. Scrobbling is so popular that even Spotify had to add native support back in the early days.
Anyway, even if you don't use scrobbling, Last.fm API provides many useful features like song, artist and listening information etc. For example "top tracks" is a killer in Subsonic.
This issue is about plain scrobbling though which would be groundbreaking already by itself.
@phanan commented on GitHub (Dec 17, 2015):
Yes, sounds convincing. I'll find a timeslot for it.
@ronilaukkarinen commented on GitHub (Dec 18, 2015):
Found this, maybe it will help you out. Studying vue/laravel myself, but it's so new to me not sure I can handle it yet. After all it would need Last.fm settings section for user credentials or approving scrobbling via redirect to get access token and that may be to complicated for me at this time.
Something as simple as below would perhaps do, but not sure how to implement it.
Very exited about this project. :)
@phanan commented on GitHub (Dec 18, 2015):
Yes, support for Last.fm is almost a certain. One can have only so much time a day though.
@ronilaukkarinen commented on GitHub (Dec 18, 2015):
@phanan Did not mean to rush at all, only trying to help out since you mentioned you don't scrobble yourself, I don't expect it to get done or making any demands whatsoever. As an active entrepreneur I know time is a relative subject. :) Thanks for doing this and have a great weekend!
@phanan commented on GitHub (Dec 18, 2015):
@ronilaukkarinen Yeah certainly. Can't say I'm any less excited than you ;)
@mecyborg commented on GitHub (Dec 18, 2015):
@ronilaukkarinen I was going to suggest this. Its a must !
@phanan commented on GitHub (Dec 19, 2015):
https://twitter.com/notphanan/status/678073237146742784 ;)
On Fri, Dec 18, 2015 at 7:34 PM, Nikunj Gupta notifications@github.com
wrote:
@ronilaukkarinen commented on GitHub (Dec 19, 2015):
@phanan Wow, this will be more than expected already. Awesome, man!
@phanan commented on GitHub (Dec 19, 2015):
Following up: https://twitter.com/notphanan/status/678255497640718336.
Those of you who want to live by the edge can pull branch 1.1 and try the new features.
I'm working on scrobbling next. Keep the ideas coming!
@ronilaukkarinen commented on GitHub (Dec 19, 2015):
@phanan Very nice, will try out 1.1 soon! However, I wish this issue to be reopened because it was originally about scrobbling per se rather than additional Last.fm features, so I'll get notified when the scrobbling will be ready and no duplicate issues will be created. Scrobbling is a more essential feature than info to me and prorably to other scrobblers out there as well. Good job so far anyway!
@ronilaukkarinen commented on GitHub (Dec 19, 2015):
Updated my keys in
.envand then didgit branch 1.1 && git checkout 1.1 && git pull origin 1.1 && npm install && composer install. No visible changes. What else do I have to do?@phanan commented on GitHub (Dec 20, 2015):
gulp --production?@phanan commented on GitHub (Dec 20, 2015):
I'll add an upgrade guide once upgrading is an official option.
@ronilaukkarinen commented on GitHub (Dec 20, 2015):
Npm runs it
But ran
gulp --productionseparately now. Maybe misunderstood what's new. I see Artists in left bar but only Lyrics in right.@phanan commented on GitHub (Dec 20, 2015):
@ronilaukkarinen See this.
Also, the last commit on 1.1 should yield something like this:
And scrobbling has been added, as long as you connect to Last.fm:
Since the functionalities are still experimental, let me know if it works.
@phanan commented on GitHub (Dec 20, 2015):
Remember to run
./artisan migratetoo.@ronilaukkarinen commented on GitHub (Dec 20, 2015):
Yeah, I did those, but no effect. Some cache thing? I had to copy .env to safe place, then run
rm -rf /var/www/html/koel, thengit clone -b 1.1 git@github.com:phanan/koel.gitand copying .env back. Now it works! Strange that the update did not. Some album covers not found, but I guess that can be fixed with resync I presume.The changes are so cool, thanks a bunch! 👍
@phanan commented on GitHub (Dec 20, 2015):
@ronilaukkarinen Maybe you can thanks me by recommending some good Finnish heavy metal albums!
@ronilaukkarinen commented on GitHub (Dec 20, 2015):
@phanan Always a pleasure! It depends what kind of metal do you like? Try Amorphis for example, you will like it. Very melodic. The newest album is great. The Four Wise Ones is one of my favourites from that new album.
@phanan commented on GitHub (Dec 20, 2015):
I don't discriminate music – from Nighwish to Sonata Arctica to Ensiferum
and COB and Korpiklaani, I love all of them ;)
Thanks for the recommendation, they sound great indeed!
On Mon, Dec 21, 2015 at 12:02 AM, Roni Laukkarinen <notifications@github.com
@ronilaukkarinen commented on GitHub (Dec 22, 2015):
Sorry to bump! Want to listen so badly, but if it doesn't scrobble, it doesn't count ;) no rush, just thought to comment to see what's the situation with scrobbling call at this time.
By the way, there is two ways to make scrobbling work, other is that after the song is played, it will be visible in Last.fm, other (preferred) more sophisticated way is to scrobble actually when the song is playing (so we can see "Now playing" indicator in Last.fm). I don't know the exact technique to this, but I've heard it's fairly simple.
@phanan commented on GitHub (Dec 23, 2015):
Huh. Have you connected your account from Settings?
Will definitely look at this. Thanks.
On Wed, Dec 23, 2015 at 4:57 AM, Roni Laukkarinen notifications@github.com
wrote:
@phanan commented on GitHub (Dec 23, 2015):
@ronilaukkarinen This?
@ronilaukkarinen commented on GitHub (Dec 27, 2015):
@phanan Yeah. Should it scrobble already? because for me, it doesn't.
@ronilaukkarinen commented on GitHub (Dec 27, 2015):
Sorry, been absent minded, didn't notice the admin connect button before. Scrobbling confirmed working now! Perfect!
@ronilaukkarinen commented on GitHub (Aug 9, 2017):
Just noticed I don't see "Scrobbling now" any more. The songs appear after playing to my profile but not during...
@phanan commented on GitHub (Aug 19, 2017):
Still kicking on my end: