starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 16:56:02 +03:00

[GH-ISSUE #1099] Clarification on the difference between sqlite-e2e and sqlite-persistent #648

New issue

Closed

opened 2026-02-26 02:33:51 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 02:33:51 +03:00

Owner

Originally created by @ysmu on GitHub (Oct 7, 2019).
Original GitHub issue: https://github.com/koel/koel/issues/1099

Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:

You have read and followed closely the Wiki, Upgrade Guide, as well as Troubleshooting
The issue has not been reported before
This is not a "how to install on Windows" or "why is my npm messed up" question
You're a cool person 🤔

All checked? Now also make sure your issue

Is associated with a version. Or better yet, a commit.
Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?)
Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know)
Is in English, 因为我不说中文。

Version: latest master (35efc6b1a3)

I'm slightly confused as to which of the sqlite-e2e and sqlite-persistent is the correct database driver for sqlite. Looking at this:
github.com/phanan/koel@35efc6b1a3/app/Console/Commands/InitCommand.php (L102-L111)
It seems like sqlite-e2e is the right one. But it's missing the fix from here:
github.com/phanan/koel@35efc6b1a3/app/Traits/SupportsDeleteWhereIDsNotIn.php (L30)

I'm also not sure why DB_DATABASE was used differently (one used as an absolute path and the other one relative path):
github.com/phanan/koel@35efc6b1a3/config/database.php (L42-L52)

As I recently encountered the "too many parameters" issue with sqlite-e2e, I think I should switch to sqlite-persistent, although I would prefer if DB_DATABASE is also an absolute path like it is in sqlite-e2e. And out of curiosity, what does e2e stand for? I was thinking of end-to-end but sqlite end-to-end doesn't make much sense. Is it for testing?

Originally created by @ysmu on GitHub (Oct 7, 2019). Original GitHub issue: https://github.com/koel/koel/issues/1099 Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue: - [x] You have read and followed closely the [Wiki](https://koel.phanan.net/docs), [Upgrade Guide](https://github.com/phanan/koel/releases), as well as [Troubleshooting](https://koel.phanan.net/docs/#/troubleshooting) - [x] The issue has not been reported before - [x] This is not a "how to install on Windows" or "why is my npm messed up" question - [ ] You're a cool person 🤔 All checked? Now also make sure your issue - [x] Is associated with a version. Or better yet, a commit. - [x] Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?) - [x] Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know) - [x] Is in English, 因为我不说中文。 Version: latest master (35efc6b1a3228ac5e26e5caf0234d169e5db9dc2) I'm slightly confused as to which of the `sqlite-e2e` and `sqlite-persistent` is the correct database driver for sqlite. Looking at this: https://github.com/phanan/koel/blob/35efc6b1a3228ac5e26e5caf0234d169e5db9dc2/app/Console/Commands/InitCommand.php#L102-L111 It seems like `sqlite-e2e` is the right one. But it's missing the fix from here: https://github.com/phanan/koel/blob/35efc6b1a3228ac5e26e5caf0234d169e5db9dc2/app/Traits/SupportsDeleteWhereIDsNotIn.php#L30 I'm also not sure why `DB_DATABASE` was used differently (one used as an absolute path and the other one relative path): https://github.com/phanan/koel/blob/35efc6b1a3228ac5e26e5caf0234d169e5db9dc2/config/database.php#L42-L52 As I recently encountered the "too many parameters" issue with `sqlite-e2e`, I think I should switch to `sqlite-persistent`, although I would prefer if `DB_DATABASE` is also an absolute path like it is in `sqlite-e2e`. And out of curiosity, what does e2e stand for? I was thinking of end-to-end but sqlite end-to-end doesn't make much sense. Is it for testing?

kerem closed this issue

2026-02-26 02:33:51 +03:00

kerem commented

2026-02-26 02:33:51 +03:00

Author

Owner

@phanan commented on GitHub (Oct 7, 2019):

Yes, sqlite-e2e is the database used for end-to-end testing, even though it's now much obsolete, as I'm planning to switch to Cypress and its server mocks. sqlite-persistent is what you want to use (even though personally I'd recommend to pick a database driver that is better supported by Laravel e.g. MySQL.

Also, I totally agree re: absolute path. Changing it will be BC breaking though.

@phanan commented on GitHub (Oct 7, 2019): Yes, `sqlite-e2e` is the database used for end-to-end testing, even though it's now much obsolete, as I'm planning to switch to Cypress and its server mocks. `sqlite-persistent` is what you want to use (even though personally I'd recommend to pick a database driver that is better supported by Laravel e.g. MySQL. Also, I totally agree re: absolute path. Changing it will be BC breaking though.

kerem commented

2026-02-26 02:33:51 +03:00

Author

Owner

@ysmu commented on GitHub (Oct 7, 2019):

Thanks for the clarification. I like sqlite for its portability but I'll try MySQL. I should have discovered this project earlier so we can make the change to absolute path before v4.0 but I guess it's a bit late 😛

@ysmu commented on GitHub (Oct 7, 2019): Thanks for the clarification. I like sqlite for its portability but I'll try MySQL. I should have discovered this project earlier so we can make the change to absolute path before v4.0 but I guess it's a bit late 😛

kerem referenced this issue

2026-02-26 02:34:03 +03:00

[GH-ISSUE #1244] Stream audio to shoutcast Server instead of listening in Browser #710

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#648

No description provided.

Rows
Columns