starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 16:56:02 +03:00

[GH-ISSUE #1087] Suggestion re: play count #639

New issue

Closed

opened 2026-02-26 02:33:49 +03:00 by kerem · 4 comments

kerem commented

2026-02-26 02:33:49 +03:00

Owner

Originally created by @tecosaur on GitHub (Sep 23, 2019).
Original GitHub issue: https://github.com/koel/koel/issues/1087

I'll keep this short.

Having play-count increment immediately seems a big over-enthusiastic to me.
I know this was supposedly changed in #619 however I've found that listening for 1 second to a track is enough.

I'm running master/HEAD.

Originally created by @tecosaur on GitHub (Sep 23, 2019). Original GitHub issue: https://github.com/koel/koel/issues/1087 I'll keep this short. Having play-count increment immediately seems a big over-enthusiastic to me. I know this was supposedly changed in #619 however I've found that listening for 1 second to a track is enough. I'm running master/HEAD.

kerem

2026-02-26 02:33:49 +03:00

closed this issue
added the
[Type] Bug
label

kerem commented

2026-02-26 02:33:50 +03:00

Author

Owner

@tecosaur commented on GitHub (Sep 23, 2019):

Made a quick gif

@tecosaur commented on GitHub (Sep 23, 2019): Made a quick gif ![playcount](https://user-images.githubusercontent.com/20903656/65404720-4c255680-de0c-11e9-9441-ac0c708beb84.gif)

kerem commented

2026-02-26 02:33:50 +03:00

Author

Owner

@phanan commented on GitHub (Sep 23, 2019):

Hmm. This looks like a regression. The song should only be counted after 10 seconds per the above-mentioned ticket.

@phanan commented on GitHub (Sep 23, 2019): Hmm. This looks like a regression. The song should only be counted after 10 seconds per the above-mentioned ticket.

kerem commented

2026-02-26 02:33:50 +03:00

Author

Owner

@tecosaur commented on GitHub (Sep 23, 2019):

A quick comment by me. While for a 2-3 minute pop song 10s may be reasonable (though tbh 30s sounds more reasonable to me) for those classical music listeners out there, in a 20-minute piece, one may decide to skip it after 2 minutes.

With this in mind perhaps something more relative — like 25% of the total track length; may be a better threshold to use.

With 25% of piece length:

20 minutes classical piece — threshold at 5 minutes
7 minute something else — theshold at 1 min 35 seconds
3 minute pop piece — theshold at 45 seconds

The above looks like it would work well to me. What are your thoughts?

@tecosaur commented on GitHub (Sep 23, 2019): A quick comment by me. While for a 2-3 minute pop song 10s may be reasonable (though tbh 30s sounds _more_ reasonable to me) for those classical music listeners out there, in a 20-minute piece, one may decide to skip it after 2 minutes. With this in mind perhaps something more relative — like 25% of the total track length; may be a better threshold to use. With 25% of piece length: - 20 minutes classical piece — threshold at 5 minutes - 7 minute something else — theshold at 1 min 35 seconds - 3 minute pop piece — theshold at 45 seconds The above looks like it would work well to me. What are your thoughts?

kerem commented

2026-02-26 02:33:50 +03:00

Author

Owner

@phanan commented on GitHub (Oct 6, 2019):

Fixed! (I don't know why I put "20%" in the commit message, but it is 25% 😅).

@phanan commented on GitHub (Oct 6, 2019): Fixed! (I don't know why I put "20%" in the commit message, but it is 25% 😅).

kerem referenced this issue

2026-02-26 03:30:32 +03:00

[PR #639] [MERGED] Apply fixes from StyleCI #1305

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#639

No description provided.

Rows
Columns