mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #956] Scrolling not possible if scrollable area is higher than initials items #608
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#608
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @p4t5h3 on GitHub (Apr 10, 2019).
Original GitHub issue: https://github.com/koel/koel/issues/956
Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:
All checked? Now also make sure your issue
Having Koel 3.7.2 and a long list of artists and albums I cannot scroll down in case my viewport has an upright aspect ratio and is high enough to display all of the intial items with whitespace below (see attached screenshot). In Safari as in Chrome on macOS Mojave.
Resizing the window into landscape aspect ratio results in the initial items always overflowing the visible scroll area and thus preventing the issue.
I guess there is a hardwired value for the initial count of items. Based on the height of the items and the scrollable view it should be calculated dynamically to fill up the whole available space.
Edit: It appears like I assumed. I cannot work on that myself for now due the lack of time. Hopefully I will in a few weeks.
https://github.com/koel/core/blob/master/js/components/screens/album-list.vue#L30
@BrookeDot commented on GitHub (Apr 22, 2020):
Closing as I believe this was fixed in #1086 I remember having the same problem in the past and haven't had it for a while now.