mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #86] nginx.conf #60
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#60
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @emtudo on GitHub (Dec 16, 2015).
Original GitHub issue: https://github.com/koel/koel/issues/86
The nginx the problem is if the guy is on a shared host it does not access the settings.
@etopian commented on GitHub (Dec 16, 2015):
no way to fix this. if you can not create a custom nginx.conf file not much that can be done. use apache instead.
@emtudo commented on GitHub (Dec 16, 2015):
I'm not problem with nginx, I suggested changing the way of security because I was told that things are this way they are, all the files before "public" because of shared server.
@etopian commented on GitHub (Dec 16, 2015):
don't put the files under the web accessible folder. koel uses absolute paths to the file system, and streams the file either through apache or php. all you have to do is make sure the permissions are set properly so the web server can read them. they don't have to be in a path accessible by the web.
@emtudo commented on GitHub (Dec 17, 2015):
I know!
To read https://github.com/phanan/koel/pull/43
@phanan commented on GitHub (Dec 17, 2015):
You guys are fixing a problem that's not there.
Every shared host that I know, if they use nginx, they use it as a proxy to Apache and has dot files protected. If they don't, just flee fast.
I guess Apache's
denydirective is for this very purpose.Anyway, again, the folder structure is like that to serve those on a shared host, who cannot install above the public folder. I will not change it just because some of us (including me too) have total control of our servers.