starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-26 09:15:59 +03:00

[GH-ISSUE #859] API Typo in "Media Streaming" #588

New issue

Closed

opened 2026-02-26 02:33:38 +03:00 by kerem · 4 comments

kerem commented

2026-02-26 02:33:38 +03:00

Owner

Originally created by @decaby7e on GitHub (Nov 21, 2018).
Original GitHub issue: https://github.com/koel/koel/issues/859

Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:

You have read and followed closely the Wiki, Upgrade Guide, as well as Troubleshooting
The issue has not been reported before
This is not a "how to install on Windows" or "why is my npm messed up" question
You're a cool person

Just a bit of nit-picking, but I noticed a typo in the API documentation. Where it says:

A GET to /api/{song_id}/play?token={token} returns the streamed media file.

'token' should be 'jwt-token'

Originally created by @decaby7e on GitHub (Nov 21, 2018). Original GitHub issue: https://github.com/koel/koel/issues/859 Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue: - [x] You have read and followed closely the [Wiki](https://koel.phanan.net/docs), [Upgrade Guide](https://github.com/phanan/koel/releases), as well as [Troubleshooting](https://koel.phanan.net/docs/#/troubleshooting) - [x] The issue has not been reported before - [x] This is not a "how to install on Windows" or "why is my npm messed up" question - [x] You're a cool person Just a bit of nit-picking, but I noticed a typo in the API documentation. Where it says: A GET to /api/{song_id}/play?token={token} returns the streamed media file. 'token' should be 'jwt-token'

kerem closed this issue

2026-02-26 02:33:38 +03:00

kerem commented

2026-02-26 02:33:38 +03:00

Author

Owner

@phanan commented on GitHub (Nov 22, 2018):

Thanks! Are you willing to submit a PR to fix this?

@phanan commented on GitHub (Nov 22, 2018): Thanks! Are you willing to submit a PR to fix this?

kerem commented

2026-02-26 02:33:38 +03:00

Author

Owner

@decaby7e commented on GitHub (Nov 22, 2018):

Sure, but where would I do this? The API docs are on Apiary.

@decaby7e commented on GitHub (Nov 22, 2018): Sure, but where would I do this? The API docs are on Apiary.

kerem commented

2026-02-26 02:33:38 +03:00

Author

Owner

@phanan commented on GitHub (Nov 22, 2018):

Ah! That doc is painfully obsolete, sorry :P

decaby7e notifications@github.com schrieb am Do. 22. Nov. 2018 um 18:31:

Sure, but where would I do this? The API docs are on Apiary.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/859#issuecomment-441091317, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrt0mAYY8JD9-fWUm7IpNPecwOBCtSYks5uxt9-gaJpZM4Yua4X
.

@phanan commented on GitHub (Nov 22, 2018): Ah! That doc is painfully obsolete, sorry :P decaby7e <notifications@github.com> schrieb am Do. 22. Nov. 2018 um 18:31: > Sure, but where would I do this? The API docs are on Apiary. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > <https://github.com/phanan/koel/issues/859#issuecomment-441091317>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AHrt0mAYY8JD9-fWUm7IpNPecwOBCtSYks5uxt9-gaJpZM4Yua4X> > . >

kerem commented

2026-02-26 02:33:38 +03:00

Author

Owner

@decaby7e commented on GitHub (Nov 22, 2018):

No problem! Just doing my part

@decaby7e commented on GitHub (Nov 22, 2018): No problem! Just doing my part

kerem referenced this issue

2026-02-26 03:30:29 +03:00

[PR #588] [MERGED] Apply fixes from StyleCI #1293

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#588

No description provided.

Rows
Columns