[GH-ISSUE #712] The selection between the rows is made between the location of the clicks and ignores the first row clicked #506

Closed
opened 2026-02-26 02:33:24 +03:00 by kerem · 1 comment
Owner

Originally created by @matiasdelellis on GitHub (Jan 23, 2018).
Original GitHub issue: https://github.com/koel/koel/issues/712

Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:

  • You have read and followed closely the Wiki, Upgrade Guide, as well as Troubleshooting. Yes
  • The issue has not been reported before.. No
  • This is not a "how to install on Windows" or "why is my npm messed up" question. No
  • You're a cool person. **I hope :😉 **

All checked? Now also make sure your issue

  • Is associated with a version. Or better yet, a commit. No. Tested between 3.7 and the last commit
  • Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?): Fedora 27, Firefox 57 and Windows 10, firefox 57**
  • Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know): Anything usefull
  • Is in English, 因为我不说中文。: Ok

Whell.. Description:

How to reproduce it?

  1. Queue some artist with many songs.
  2. Click on a song to try to select a range of songs..
  3. Move on the list by scrolling to find the last song to select where you want to select
  4. SHIFT + CLICK on last song that you want to select.

Expected result:

All songs must be selected between the first song clicked and the last one

Current result

The selection is made taking into account where you click -Positioning the cursor on the screen-. After the scroll, the position of the click, does not correspond to the last selected row. Therefore, the selection is made incorrectly, between the last click, and a row that is now where the first selection was before.
As a consequence, if you did not notice, you deleted the wrong songs from the playback queue. 😞

Originally created by @matiasdelellis on GitHub (Jan 23, 2018). Original GitHub issue: https://github.com/koel/koel/issues/712 Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue: - [x] You have read and followed closely the [Wiki](https://koel.phanan.net/docs), [Upgrade Guide](https://github.com/phanan/koel/releases), as well as [Troubleshooting](https://koel.phanan.net/docs/#/troubleshooting). **Yes** - [x] The issue has not been reported before.. **No** - [x] This is not a "how to install on Windows" or "why is my npm messed up" question. **No** - [x] You're a cool person. **I hope ::wink: ** All checked? Now also make sure your issue - [x] Is associated with a version. Or better yet, a commit. **No. Tested between 3.7 and the last commit** - [x] Is as detailed as possible (ahem... OS, browser, steps to reproduce, maybe?): Fedora 27, Firefox 57 and Windows 10, firefox 57** - [x] Includes the error output if it's a bug/error report ("Whoops!" is not very helpful, you know): **Anything usefull** - [x] Is in English, 因为我不说中文。: **Ok** ## Whell.. Description: ### How to reproduce it? 1. Queue some artist with many songs. 2. Click on a song to try to select a range of songs.. 3. Move on the list by scrolling to find the last song to select where you want to select 4. SHIFT + CLICK on last song that you want to select. ### Expected result: All songs must be selected between the first song clicked and the last one ### Current result The selection is made taking into account where you click -Positioning the cursor on the screen-. After the scroll, the position of the click, does not correspond to the last selected row. Therefore, the selection is made incorrectly, between the last click, and a row that is now where the first selection was before. As a consequence, if you did not notice, you deleted the wrong songs from the playback queue. 😞
kerem 2026-02-26 02:33:24 +03:00
Author
Owner

@phanan commented on GitHub (Sep 23, 2022):

WNF. This is a limitation of virtual lists.

<!-- gh-comment-id:1256047541 --> @phanan commented on GitHub (Sep 23, 2022): WNF. This is a limitation of virtual lists.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#506
No description provided.