starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 00:36:03 +03:00

[GH-ISSUE #561] Flac Transcoding with non ASCII Titles #402

New issue

Open

opened 2026-02-26 02:33:06 +03:00 by kerem · 6 comments

kerem commented

2026-02-26 02:33:06 +03:00

Owner

Originally created by @mariuskreutzer on GitHub (Mar 16, 2017).
Original GitHub issue: https://github.com/koel/koel/issues/561

The default flac encoding doesn't work with Non-ASCII File names, as escapeshellarg seems to remove these characters by default.
When I insert setlocale(LC_CTYPE, "de_DE.UTF-8");
before the $args line it works.

Originally created by @mariuskreutzer on GitHub (Mar 16, 2017). Original GitHub issue: https://github.com/koel/koel/issues/561 The default flac encoding doesn't work with Non-ASCII File names, as escapeshellarg seems to remove these characters by default. When I insert setlocale(LC_CTYPE, "de_DE.UTF-8"); before the $args line it works.

kerem added the

Flac

[Status] Needs Author Reply

labels

2026-02-26 02:33:06 +03:00

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@BrookeDot commented on GitHub (Apr 22, 2020):

Can you give the steps to reproduce, for example a file name that is failing?

@BrookeDot commented on GitHub (Apr 22, 2020): Can you give the steps to reproduce, for example a file name that is failing?

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@BrookeDot commented on GitHub (Apr 22, 2020):

Another example from #728

Services/Streamers/TranscodingStreamer.php line 45

   // When escapeshellarg() was stripping my non-ASCII characters from a UTF-8 string, 
  //adding the following fixed the problem:
        setlocale(LC_CTYPE, "en_US.UTF-8");
        $args = [
            '-i '.escapeshellarg($this->song->path),
            '-map 0:0',
            '-v 0',
            "-ab {$bitRate}k",
            '-f mp3',
            '-',
        ];

Possibly could be resolved by allowing a new env setting to set the type.

@BrookeDot commented on GitHub (Apr 22, 2020): Another example from #728 ``` Services/Streamers/TranscodingStreamer.php line 45 // When escapeshellarg() was stripping my non-ASCII characters from a UTF-8 string, //adding the following fixed the problem: setlocale(LC_CTYPE, "en_US.UTF-8"); $args = [ '-i '.escapeshellarg($this->song->path), '-map 0:0', '-v 0', "-ab {$bitRate}k", '-f mp3', '-', ]; ``` Possibly could be resolved by allowing a new `env` setting to set the type.

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@Hyzual commented on GitHub (Apr 25, 2020):

Hi, I can confirm this problem. Here is a filename that reproduces it: 01.エイミー.flac
The same file, when named 12- Glenn Stafford - Zerg Two.flac plays fine.

@Hyzual commented on GitHub (Apr 25, 2020): Hi, I can confirm this problem. Here is a filename that reproduces it: `01.エイミー.flac` The same file, when named `12- Glenn Stafford - Zerg Two.flac` plays fine.

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@sweetlazyboy commented on GitHub (Dec 18, 2020):

I insert
setlocale(LC_CTYPE, "zh_CN.UTF-8");
before the $args line, but still not works.
setlocale(LC_CTYPE, "en_US.UTF-8");
not work, too

@sweetlazyboy commented on GitHub (Dec 18, 2020): I insert setlocale(LC_CTYPE, "zh_CN.UTF-8"); before the $args line, but still not works. setlocale(LC_CTYPE, "en_US.UTF-8"); not work, too

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@bitxel commented on GitHub (Mar 28, 2021):

@sweetlazyboy you need to check whether this locale is in your OS or not by running locale -a

for my case, I need to insert setlocale(LC_CTYPE, "C.UTF-8");

@bitxel commented on GitHub (Mar 28, 2021): @sweetlazyboy you need to check whether this locale is in your OS or not by running `locale -a` for my case, I need to insert `setlocale(LC_CTYPE, "C.UTF-8");`

kerem commented

2026-02-26 02:33:06 +03:00

Author

Owner

@maxysoft commented on GitHub (Jun 1, 2021):

@sweetlazyboy you need to check whether this locale is in your OS or not by running locale -a

for my case, I need to insert setlocale(LC_CTYPE, "C.UTF-8");

I can confirm that the following edit fixed my problem. In that case I have the same locale.

@maxysoft commented on GitHub (Jun 1, 2021): > > > @sweetlazyboy you need to check whether this locale is in your OS or not by running `locale -a` > > for my case, I need to insert `setlocale(LC_CTYPE, "C.UTF-8");` I can confirm that the following edit fixed my problem. In that case I have the same locale.

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#402

No description provided.

Rows
Columns