mirror of
https://github.com/koel/koel.git
synced 2026-04-27 01:35:59 +03:00
[GH-ISSUE #550] Prefetching doesn't work :( #392
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#392
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @o355 on GitHub (Mar 6, 2017).
Original GitHub issue: https://github.com/koel/koel/issues/550
Hey, thanks for contributing to Koel! To save time for both of us, please make sure these checkboxes are checked before submitting the issue:
All checked? Now also make sure your issue
So, prefetching doesn't work. I've been listening to an EP, and on my stellar 200 Mbps local Wi-Fi, Koel isn't prefetching the song, and playing the next song. Since my Wi-Fi is fast, music will not play for a second (500-1000ms), but I could imagine this being worse on a mobile network (Verizon)
OS on the server is Ubuntu Server 16.04.2 LTS. On the client side, Kubuntu 16.10, using Chrome 56.
@o355 commented on GitHub (Mar 6, 2017):
Bit of an update, either time is flying by too quickly, or the prefetch delay is almost gone. Not sure which of the two it is, but...
I'll listen more closely.
EDIT: Nope, still broken :(
@phanan commented on GitHub (Mar 6, 2017):
Weird. It's working perfectly for me, Chrome 56, Mac.
@o355 commented on GitHub (Mar 6, 2017):
Huh. I'll certainly pull up the network tab, and see what's going on.
I don't know if having another tab open causes an issue, but I'll try it in the foreground/background in Chrome.
@o355 commented on GitHub (Mar 7, 2017):
So, as seen here, it appears as if Koel is prefetching the next song, but when the next song begins to play, Koel fetches the file again (for some reason), but there's still a delay between songs. I'm going to try and throttle Chrome, and truly see if prefetching is enabled.
@o355 commented on GitHub (Mar 7, 2017):
Here's what I'm generally noticing. Koel indeed prefetches the song that's upcoming next, but after a song has ended, and it moves on to the next song, Koel again fetches the song, which is really odd. Anywhom, it's happened 100% of the time, when throttling Chrome down to "Good 4G".
@phanan commented on GitHub (Mar 7, 2017):
Hmm. I'll take a look at this. Maybe there's a change in the API, or maybe the implementation is wrong from the beginning (which is unlikely). Thanks for the very detailed issue report!
@o355 commented on GitHub (Mar 7, 2017):
No problem! Always happy to help. Also, I'm seeing some ERR_CONTENT_LENGTH_MISMATCH errors coming up in Chrome's network waterfall, when Koel is running in the background, so that's interesting.
@phanan commented on GitHub (Mar 7, 2017):
Yeah, that's very normal.
@Andy-H-Nguyen commented on GitHub (Mar 16, 2017):
Yes, it seems to be fetching twice for me, and there is delay between songs. I am running on the client on Chrome 56 on Windows 8, the server is running on ubuntu 14.04.
@phanan commented on GitHub (Mar 22, 2017):
What streaming method are you guys using?
x-sendfileandx-accel-redirectwork for me. Forphp(default) looks like we need a way to cache the content streamed by PHP, which I don't know how to do.@Andy-H-Nguyen commented on GitHub (Mar 22, 2017):
Yes, I am running using php. Haven't gotten the chance to try
x-sendfileandx-accel-redirectyet.@o355 commented on GitHub (Mar 22, 2017):
I'm using what's set by default with Koel (so I assume
php).