mirror of
https://github.com/koel/koel.git
synced 2026-04-25 08:46:00 +03:00
[GH-ISSUE #545] npm install fails on master branch #386
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#386
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @alex-phillips on GitHub (Feb 23, 2017).
Original GitHub issue: https://github.com/koel/koel/issues/545
It looks like
npm installfails on the master branch. Is this known?@phanan commented on GitHub (Feb 24, 2017):
Erm… no? The build still passes on Travis.
@alex-phillips commented on GitHub (Feb 24, 2017):
will try again real quick, but i pulled now a fresh master today and it failed. Will paste my output if i fails again.
@alex-phillips commented on GitHub (Feb 24, 2017):
Here's my output:
@phanan commented on GitHub (Feb 24, 2017):
Can you try
yarninstead ofnpm install?@phanan commented on GitHub (Feb 24, 2017):
Looks like
npm installpulls a newer, breaking, version of Laravel Mix.@alex-phillips commented on GitHub (Feb 24, 2017):
Ok, that looks like it did it. Thanks!
@vesper8 commented on GitHub (Mar 17, 2017):
this really should be changed so that it's compatible with the latest laravel mix. I too was using npm and ran into the same error. Not sure why it works with yarn.. probably because of the yarn.lock file preventing it from getting the latest laravel mix. But "use yarn instead" and closing the issue feels incomplete to me.
@phanan commented on GitHub (Mar 17, 2017):
The official docs state the use of yarn, so no, I don't think it's incomplete.
@gerroon commented on GitHub (Jun 7, 2018):
The official doc mentions yarn but it does not say use yarn instead of npm. Please correct it.
@phanan commented on GitHub (Jun 7, 2018):
@gerroon It's because you don't even need to execute any yarn or npm yourself. There's nothing to correct.
@gerroon commented on GitHub (Jun 7, 2018):
@phanan
Well I am not sure then because I followed exact these steps in the docs,
I was getting bunch of php errors in the page when I tried to open the page.
Then I downgraded to nodejs to 6 (I originally had nodejs 8 I believe) and used yarn then composer and it worked.
@gerroon commented on GitHub (Jun 7, 2018):
@phanan
Just to prove my point I did a clean install from scratch without using "yarn", I did steps that the doc says, which I posted above entry.
This is what I get in the browser when trying to open the page (unless I run yarn install prior)
So I am not sure how I can relate to your comment about the user not needeing to fire yarn/npm install