starred/koel-koel

Fork 0

mirror of https://github.com/koel/koel.git synced 2026-04-25 08:46:00 +03:00

[GH-ISSUE #524] Non optional dependency on Sentry #372

New issue

Closed

opened 2026-02-26 02:32:59 +03:00 by kerem · 2 comments

kerem commented

2026-02-26 02:32:59 +03:00

Owner

Originally created by @X-Ryl669 on GitHub (Jan 18, 2017).
Original GitHub issue: https://github.com/koel/koel/issues/524

Currently, the last version added a dependency on Sentry that's not optional.
This sends logs of exception to an account on sentry.io (@phanan, is it your account ?)

Why did not you use LERN instead (since this allow to send the exceptions to email for example if one wanted this) ?
How do you disable this ?

Worst, now the exceptions while developing on my branch will be sent to Sentry's servers, then you (you probably don't care about them, but I do).
This adds a huge sniffer in the code, they get my server name, and all the list of my songs.
Example of what it sends to them:

{"project":"120890","logger":"javascript","platform":"javascript","request":{"headers":{"User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36",
"Referer":"http://**MYSERVERHERE**"},
"url":"http://**MYSERVERHERE**"},"exception":{"values":[{"type":"TypeError","value":"Cannot read property 'length' of undefined","stacktrace":{"frames":[{
"filename":"http://**MYSERVERHERE**/public/build/js/main-a6d09864a5.js","lineno":40596,"colno":16,"function":"nextTickHandler","in_app":true},

[...] // Edited to remove the complete callstack list 
,"culprit":"http://**MYSERVERHERE**/public/build/js/main-a6d09864a5.js",
"extra":{"componentName":"component <folder-item>","propsData":{"level":0,"folder":{"data":
{"name":"Media Library","songId":0,"children":[
{"name":"Enfants","songId":0,"children":
[{"name":"**MYSONGSHERE**","songId":0,"children":[{"name":"**SOMEOFMYFILESHERE**.mp3","songId":"632aa367cb145af25ce3a5586cf0a676","children":[]},

[...] // Edited, but it contains the list of all my songs

Honestly, using Sentry should be a personal stuff you set on your/my development branch not something that's on for all user without them knowing about the sniffer.

Also, on Javascript side, I can not use the "Break on uncaught exception" anymore, since Raven/Sentry is catching all of them, so I can't even deal with those exception by myself.

Originally created by @X-Ryl669 on GitHub (Jan 18, 2017). Original GitHub issue: https://github.com/koel/koel/issues/524 Currently, the last version added a dependency on Sentry that's not optional. This sends logs of exception to an account on sentry.io (@phanan, is it your account ?) Why did not you use LERN instead (since this allow to send the exceptions to email for example if one wanted this) ? How do you disable this ? Worst, now the exceptions while developing on my branch will be sent to Sentry's servers, then you (you probably don't care about them, but I do). This adds a huge sniffer in the code, they get my server name, and all the list of my songs. Example of what it sends to them: ``` {"project":"120890","logger":"javascript","platform":"javascript","request":{"headers":{"User-Agent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_11_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/55.0.2883.95 Safari/537.36", "Referer":"http://**MYSERVERHERE**"}, "url":"http://**MYSERVERHERE**"},"exception":{"values":[{"type":"TypeError","value":"Cannot read property 'length' of undefined","stacktrace":{"frames":[{ "filename":"http://**MYSERVERHERE**/public/build/js/main-a6d09864a5.js","lineno":40596,"colno":16,"function":"nextTickHandler","in_app":true}, [...] // Edited to remove the complete callstack list ,"culprit":"http://**MYSERVERHERE**/public/build/js/main-a6d09864a5.js", "extra":{"componentName":"component <folder-item>","propsData":{"level":0,"folder":{"data": {"name":"Media Library","songId":0,"children":[ {"name":"Enfants","songId":0,"children": [{"name":"**MYSONGSHERE**","songId":0,"children":[{"name":"**SOMEOFMYFILESHERE**.mp3","songId":"632aa367cb145af25ce3a5586cf0a676","children":[]}, [...] // Edited, but it contains the list of all my songs ``` Honestly, using Sentry should be a personal stuff you set on your/my development branch not something that's on for all user without them knowing about the sniffer. Also, on Javascript side, I can not use the "Break on uncaught exception" anymore, since Raven/Sentry is catching all of them, so I can't even deal with those exception by myself.

kerem closed this issue

2026-02-26 02:32:59 +03:00

kerem commented

2026-02-26 02:32:59 +03:00

Author

Owner

@phanan commented on GitHub (Jan 19, 2017):

Sentry is an experiment, and it's meant for production to help me learn more about the various errors occurred with Koel in different environments. In all honesty, though, it didn't help that much (and the problems with dev, too), so I'm about to remove it myself as well.

@phanan commented on GitHub (Jan 19, 2017): Sentry is an experiment, and it's meant for production to help me learn more about the various errors occurred with Koel in different environments. In all honesty, though, it didn't help that much (and the problems with dev, too), so I'm about to remove it myself as well.

kerem commented

2026-02-26 02:32:59 +03:00

Author

Owner

@X-Ryl669 commented on GitHub (Jan 19, 2017):

Thanks.

@X-Ryl669 commented on GitHub (Jan 19, 2017): Thanks.

kerem referenced this issue

2026-02-26 02:35:53 +03:00

[PR #372] [MERGED] Applied fixes from StyleCI #1227

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

starred/koel-koel#372

No description provided.

Rows
Columns