[GH-ISSUE #467] Omitting files when scanning if they contains "$" in tags #328

Closed
opened 2026-02-26 02:32:52 +03:00 by kerem · 9 comments
Owner

Originally created by @SkipperLappen on GitHub (Sep 27, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/467

Dollar-sign in mp3 tags causes file not to be scanned. I have some files where the tag "Price paid" contains $1.40. When deleting the tag in the mp3-file there is no issues.

Originally created by @SkipperLappen on GitHub (Sep 27, 2016). Original GitHub issue: https://github.com/koel/koel/issues/467 Dollar-sign in mp3 tags causes file not to be scanned. I have some files where the tag "Price paid" contains $1.40. When deleting the tag in the mp3-file there is no issues.
kerem 2026-02-26 02:32:52 +03:00
Author
Owner

@phanan commented on GitHub (Sep 28, 2016):

By "not be scanned," did you mean an error (please paste the error) or the file is just silently skipped?

<!-- gh-comment-id:250045507 --> @phanan commented on GitHub (Sep 28, 2016): By "not be scanned," did you mean an error (please paste the error) or the file is just silently skipped?
Author
Owner

@SkipperLappen commented on GitHub (Sep 28, 2016):

Sorry I was unclear. The file is silently being skipped when scanning.

<!-- gh-comment-id:250095417 --> @SkipperLappen commented on GitHub (Sep 28, 2016): Sorry I was unclear. The file is silently being skipped when scanning.
Author
Owner

@phanan commented on GitHub (Sep 28, 2016):

Actually what's the "price paid" tag…? I've never seen any media file with such a tag before. Is it a possibility to send me the file?

<!-- gh-comment-id:250096850 --> @phanan commented on GitHub (Sep 28, 2016): Actually what's the "price paid" tag…? I've never seen any media file with such a tag before. Is it a possibility to send me the file?
Author
Owner

@SkipperLappen commented on GitHub (Sep 28, 2016):

I'm using Yate (http://www.2manyrobots.com) for tagging all of my music. In Yate you can see all tags within the file, and in the sheet "Privacy" you have the "Price Paid" tag. I can send you a file, but you can try for yourself with one of your own files and entering a dollar-sign in the field. If not, I will send you a file.

<!-- gh-comment-id:250100745 --> @SkipperLappen commented on GitHub (Sep 28, 2016): I'm using Yate (http://www.2manyrobots.com) for tagging all of my music. In Yate you can see all tags within the file, and in the sheet "Privacy" you have the "Price Paid" tag. I can send you a file, but you can try for yourself with one of your own files and entering a dollar-sign in the field. If not, I will send you a file.
Author
Owner

@phanan commented on GitHub (Sep 28, 2016):

Sounds good!

On Wed, Sep 28, 2016 at 4:11 PM, SkipperLappen notifications@github.com
wrote:

I'm using Yate (http://www.2manyrobots.com) for tagging all of my music.
In Yate you can see all tags within the file, and in the sheet "Privacy"
you have the "Price Paid" tag. I can send you a file, but you can try for
yourself with one of your own files and entering a dollar-sign in the
field. If not, I will send you a file.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/467#issuecomment-250100745, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrt0lI5xTeIVJC8yScDgEvCVmvqwekNks5quiE0gaJpZM4KH8CL
.

<!-- gh-comment-id:250101097 --> @phanan commented on GitHub (Sep 28, 2016): Sounds good! On Wed, Sep 28, 2016 at 4:11 PM, SkipperLappen notifications@github.com wrote: > I'm using Yate (http://www.2manyrobots.com) for tagging all of my music. > In Yate you can see all tags within the file, and in the sheet "Privacy" > you have the "Price Paid" tag. I can send you a file, but you can try for > yourself with one of your own files and entering a dollar-sign in the > field. If not, I will send you a file. > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > https://github.com/phanan/koel/issues/467#issuecomment-250100745, or mute > the thread > https://github.com/notifications/unsubscribe-auth/AHrt0lI5xTeIVJC8yScDgEvCVmvqwekNks5quiE0gaJpZM4KH8CL > .
Author
Owner

@phanan commented on GitHub (Oct 3, 2016):

@SkipperLappen I confirm this to be a bug, but with the getID3 lib apparently and not Koel itself. I've submitted a PR there, let's hear from James.

<!-- gh-comment-id:251069619 --> @phanan commented on GitHub (Oct 3, 2016): @SkipperLappen I confirm this to be a bug, but with the [getID3](https://github.com/JamesHeinrich/getID3) lib apparently and not Koel itself. I've submitted a PR there, let's hear from James.
Author
Owner

@phanan commented on GitHub (Jan 14, 2017):

@SkipperLappen The author of getID3 has released a new version with my fix in it. Can you verify the fix?

<!-- gh-comment-id:272628311 --> @phanan commented on GitHub (Jan 14, 2017): @SkipperLappen The author of getID3 has released a new version with my fix in it. Can you verify the fix?
Author
Owner

@SkipperLappen commented on GitHub (Jan 14, 2017):

I just tried your master branch of koel and I can confirm that files with “$” in tags gets scanned.

On 14. jan. 2017 15.41 +0100, Phan An notifications@github.com, wrote:

@SkipperLappen The author of getID3 has released a new version with my fix in it. Can you verify the fix?

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.

<!-- gh-comment-id:272651526 --> @SkipperLappen commented on GitHub (Jan 14, 2017): I just tried your master branch of koel and I can confirm that files with “$” in tags gets scanned. On 14. jan. 2017 15.41 +0100, Phan An <notifications@github.com>, wrote: > @SkipperLappen The author of getID3 has released a new version with my fix in it. Can you verify the fix? > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread.
Author
Owner

@phanan commented on GitHub (Jan 15, 2017):

Great! Thank you!

<!-- gh-comment-id:272665022 --> @phanan commented on GitHub (Jan 15, 2017): Great! Thank you!
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#328
No description provided.