mirror of
https://github.com/koel/koel.git
synced 2026-04-26 09:15:59 +03:00
[GH-ISSUE #467] Omitting files when scanning if they contains "$" in tags #328
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#328
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @SkipperLappen on GitHub (Sep 27, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/467
Dollar-sign in mp3 tags causes file not to be scanned. I have some files where the tag "Price paid" contains $1.40. When deleting the tag in the mp3-file there is no issues.
@phanan commented on GitHub (Sep 28, 2016):
By "not be scanned," did you mean an error (please paste the error) or the file is just silently skipped?
@SkipperLappen commented on GitHub (Sep 28, 2016):
Sorry I was unclear. The file is silently being skipped when scanning.
@phanan commented on GitHub (Sep 28, 2016):
Actually what's the "price paid" tag…? I've never seen any media file with such a tag before. Is it a possibility to send me the file?
@SkipperLappen commented on GitHub (Sep 28, 2016):
I'm using Yate (http://www.2manyrobots.com) for tagging all of my music. In Yate you can see all tags within the file, and in the sheet "Privacy" you have the "Price Paid" tag. I can send you a file, but you can try for yourself with one of your own files and entering a dollar-sign in the field. If not, I will send you a file.
@phanan commented on GitHub (Sep 28, 2016):
Sounds good!
On Wed, Sep 28, 2016 at 4:11 PM, SkipperLappen notifications@github.com
wrote:
@phanan commented on GitHub (Oct 3, 2016):
@SkipperLappen I confirm this to be a bug, but with the getID3 lib apparently and not Koel itself. I've submitted a PR there, let's hear from James.
@phanan commented on GitHub (Jan 14, 2017):
@SkipperLappen The author of getID3 has released a new version with my fix in it. Can you verify the fix?
@SkipperLappen commented on GitHub (Jan 14, 2017):
I just tried your master branch of koel and I can confirm that files with “$” in tags gets scanned.
On 14. jan. 2017 15.41 +0100, Phan An notifications@github.com, wrote:
@phanan commented on GitHub (Jan 15, 2017):
Great! Thank you!