mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #465] Get rid of Pusher #325
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#325
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @X-Ryl669 on GitHub (Sep 26, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/465
As of today, the last repository requires Pusher to be installed.
BTW,
composer require pusher/pusher-php-serverneeds to be called else it won't build.I don't want to use Pusher for 2 reasons:
Please reconsider using that dependency.
@ArcheTwist commented on GitHub (Sep 26, 2016):
I totally agree, this absolutely needs to be changed if possible
@ShenZhouHong commented on GitHub (Sep 26, 2016):
I attempted to run an install as well, and the build also failed. How do I modify the file so that it would install successfully? I tried editing composer.json to add the pusher file in with an version number of "*", but it still appears not to work.
@ShenZhouHong commented on GitHub (Sep 26, 2016):
Even trying the command
composer require pusher/pusher-php-serverdoes not seem to work:@BernardGoldberger commented on GitHub (Sep 26, 2016):
You need to add
BROADCAST_DRIVER=loginto.envand runcomposer install.@ShenZhouHong commented on GitHub (Sep 26, 2016):
The problem is that the env file is never generated, since composer install exits with an error. I ended up downloading a slightly older version of koel from the releases, and now it is working fantastically.
@BernardGoldberger commented on GitHub (Sep 26, 2016):
@peterpacz1 you could always create it manually.
@BernardGoldberger commented on GitHub (Sep 26, 2016):
@X-Ryl669
Did not require it for me, see https://github.com/phanan/koel/issues/465#issuecomment-249646934.
It is suggesting though that I install it.
@ShenZhouHong commented on GitHub (Sep 26, 2016):
Ah, apologies - I did not knew I could do that. Thank you for the help anyways. :)
@phanan commented on GitHub (Sep 27, 2016):
As @bdgold stated, you need to add
BROADCAST_DRIVER=loginto.envif you want to build themasterbranch. This has NOTHING to do with Pusher or Koel, but a Laravel 5.3 requirement instead.@X-Ryl669 No one is forcing you to use Pusher. Except for the core functionalities, no Koel features (YouTube, Last.fm, AWS, FFmpeg, CDN-support) are ever mandatory.
I want to stress as well, that by using
master, you guys are basically living on the edge and willing to accept broken features and/or lack of documentation. So do me and yourselves a favor of researching before jumping into conclusions, or worse, giving commands. OSS project owners don't owe you guys anything.@X-Ryl669 commented on GitHub (Sep 27, 2016):
@bdgold If you are using production code, and you don't use broadcasting, then
BROADCAST_DRIVER=logshould probably beBROADCAST_DRIVER=nullto avoid cluttering the logs.@phanan I don't see where using log driver for event broadcasting (which is a no-op as you stated) is a Laravel 5.3 requirement, the default is Pusher in Laravel 5.3. Better choice would have been the
nulldriver if you don't intend to use the feature.You don't owe us anything, that's true. Same as I don't owe you anything, yet, I'm contributing back each of my changes (you're rejecting or not, I don't care, I do what I consider fair).
In all cases, that does not mean we can't say when something do not please us.
Here's a live example where I expressed my opinion politely. I did not "give command".
I did research and figure out how to solve the missing Pusher dependency, and without any other information.
I reported the issue, and said what I did to solve it. I did not know if you were aware of it, and I supposed you did not.
If you don't like being told that something's broken, great, I'll stop reporting.
If you don't like to know what your user like/don't like, great, I'll stop reporting too.
Very positive attitude...
@phanan commented on GitHub (Sep 27, 2016):
Not to continue this very non-constructive debate, but if "Get rid of Pusher" doesn't sound like a command, I don't know what does.
Now to the root of the issue, yes, I very much intend to use broadcast in the future.