mirror of
https://github.com/koel/koel.git
synced 2026-04-25 16:56:02 +03:00
[GH-ISSUE #450] Not seeing all albums that start with number or character #317
Labels
No labels
Authentication
Dependencies
Documentation
Feature Request
Flac
Help Wanted
Installation/Setup
Integration
Mobile
PR Welcome
Pending Release
Performance
Playlist
S3
Search
Sync
[Pri] Low
[Pri] Normal
[Status] Keep Open
[Status] Needs Author Reply
[Status] Needs Review
[Status] Stale
[Status] Will Implement
[Type] Blessed
[Type] Bug
[Type] Duplicate
[Type] Enhancement
[Type] Help Request
[Type] Question
[Type] Task
pull-request
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
starred/koel-koel#317
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @ronilaukkarinen on GitHub (Sep 15, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/450
I have noticed I don't see albums like .neon by Lantlôs or 1184 by Windir, although they do exist. Why is this?
@BernardGoldberger commented on GitHub (Sep 15, 2016):
@ronilaukkarinen
Lantlôscontains unicode which if you are on windows will not be scanned.@ronilaukkarinen commented on GitHub (Sep 15, 2016):
I'm on Fedora 22 linux and Subsonic or Musiccabinet see these albums just fine.
@BernardGoldberger commented on GitHub (Sep 15, 2016):
Do they all contain unicode in the filename or path?
@ronilaukkarinen commented on GitHub (Sep 15, 2016):
Yeah, this one is practically "hidden".
@phanan commented on GitHub (Sep 15, 2016):
I think Symfony's
FinderignoreDotFiles()by default. Will test and fix.@phanan commented on GitHub (Sep 15, 2016):
@ronilaukkarinen I can't reproduce the issue with digit-only directories, though. Mine works well.
@X-Ryl669 commented on GitHub (Sep 16, 2016):
On Unix, it's a convention that folder and files starting with a '.' are ignored. If you start including them, then you'll see a lot of "not safe for users" garbage in the file list. Maybe it's better to rename your album on the filesystem with something else, as this folder will also be hidden in the standard file explorer, any standard commands (like
cp * /whatever,ls), etc...Typically, having Symfony listing all those "cache" directory will make the file listing much much slower (think of
.gitfolders for example, and the zillions objects in objects subfolder), for a very low benefit.At least, @phanan, make the ignoreDotFiles be true by default, and let it change behaviour with an option from the env file, and not the default.
@phanan commented on GitHub (Sep 17, 2016):
Your points are all right, except that the media folders typically don't
have cache or git. But yes, the idea of the .env file makes much sense
👍
On Sat, Sep 17, 2016 at 2:36 AM, X-Ryl669 notifications@github.com wrote:
@phanan commented on GitHub (Sep 17, 2016):
Closing with
e4f0027f6a.@X-Ryl669 commented on GitHub (Sep 18, 2016):
@phanan : Thanks for the fix. There's however a small spelling mistake (it's
ignoreDotFileand notingoreDotFile).