[GH-ISSUE #450] Not seeing all albums that start with number or character #317

Closed
opened 2026-02-26 02:32:49 +03:00 by kerem · 10 comments
Owner

Originally created by @ronilaukkarinen on GitHub (Sep 15, 2016).
Original GitHub issue: https://github.com/koel/koel/issues/450

I have noticed I don't see albums like .neon by Lantlôs or 1184 by Windir, although they do exist. Why is this?

Originally created by @ronilaukkarinen on GitHub (Sep 15, 2016). Original GitHub issue: https://github.com/koel/koel/issues/450 I have noticed I don't see albums like **.neon** by Lantlôs or **1184** by Windir, although they do exist. Why is this?
kerem closed this issue 2026-02-26 02:32:49 +03:00
Author
Owner

@BernardGoldberger commented on GitHub (Sep 15, 2016):

@ronilaukkarinen Lantlôs contains unicode which if you are on windows will not be scanned.

<!-- gh-comment-id:247301777 --> @BernardGoldberger commented on GitHub (Sep 15, 2016): @ronilaukkarinen `Lantlôs` contains unicode which if you are on windows will not be scanned.
Author
Owner

@ronilaukkarinen commented on GitHub (Sep 15, 2016):

I'm on Fedora 22 linux and Subsonic or Musiccabinet see these albums just fine.

<!-- gh-comment-id:247301947 --> @ronilaukkarinen commented on GitHub (Sep 15, 2016): I'm on Fedora 22 linux and Subsonic or Musiccabinet see these albums just fine.
Author
Owner

@BernardGoldberger commented on GitHub (Sep 15, 2016):

Do they all contain unicode in the filename or path?

<!-- gh-comment-id:247303154 --> @BernardGoldberger commented on GitHub (Sep 15, 2016): Do they all contain unicode in the filename or path?
Author
Owner

@ronilaukkarinen commented on GitHub (Sep 15, 2016):

Yeah, this one is practically "hidden".

[14:41:08] [39.0°C] rolle .neon $ pwd
/media/giant/levyt/Lantlôs/.neon
<!-- gh-comment-id:247305562 --> @ronilaukkarinen commented on GitHub (Sep 15, 2016): Yeah, this one is practically "hidden". ``` [14:41:08] [39.0°C] rolle .neon $ pwd /media/giant/levyt/Lantlôs/.neon ```
Author
Owner

@phanan commented on GitHub (Sep 15, 2016):

I think Symfony's Finder ignoreDotFiles() by default. Will test and fix.

<!-- gh-comment-id:247326007 --> @phanan commented on GitHub (Sep 15, 2016): I think Symfony's `Finder` `ignoreDotFiles()` by default. Will test and fix.
Author
Owner

@phanan commented on GitHub (Sep 15, 2016):

@ronilaukkarinen I can't reproduce the issue with digit-only directories, though. Mine works well.

<!-- gh-comment-id:247327937 --> @phanan commented on GitHub (Sep 15, 2016): @ronilaukkarinen I can't reproduce the issue with digit-only directories, though. Mine works well.
Author
Owner

@X-Ryl669 commented on GitHub (Sep 16, 2016):

On Unix, it's a convention that folder and files starting with a '.' are ignored. If you start including them, then you'll see a lot of "not safe for users" garbage in the file list. Maybe it's better to rename your album on the filesystem with something else, as this folder will also be hidden in the standard file explorer, any standard commands (like cp * /whatever, ls), etc...

Typically, having Symfony listing all those "cache" directory will make the file listing much much slower (think of .git folders for example, and the zillions objects in objects subfolder), for a very low benefit.

At least, @phanan, make the ignoreDotFiles be true by default, and let it change behaviour with an option from the env file, and not the default.

<!-- gh-comment-id:247675363 --> @X-Ryl669 commented on GitHub (Sep 16, 2016): On Unix, it's a convention that folder and files starting with a '.' are ignored. If you start including them, then you'll see a lot of "not safe for users" garbage in the file list. Maybe it's better to rename your album on the filesystem with something else, as this folder will also be hidden in the standard file explorer, any standard commands (like `cp * /whatever`, `ls`), etc... Typically, having Symfony listing all those "cache" directory will make the file listing much much slower (think of `.git` folders for example, and the zillions objects in objects subfolder), for a very low benefit. At least, @phanan, make the ignoreDotFiles be true by default, and let it change behaviour with an option from the env file, and not the default.
Author
Owner

@phanan commented on GitHub (Sep 17, 2016):

Your points are all right, except that the media folders typically don't
have cache or git. But yes, the idea of the .env file makes much sense
👍

On Sat, Sep 17, 2016 at 2:36 AM, X-Ryl669 notifications@github.com wrote:

On Unix, it's a convention that folder and files starting with a '.' are
ignored. If you start including them, then you'll see a lot of "not safe
for users" garbage in the file list. Maybe it's better to rename your album
on the filesystem with something else, as this folder will also be hidden
in the standard file explorer, any standard commands (like cp * /whatever,
ls), etc...

Typically, having Symfony listing all those "cache" directory will make
the file listing much much slower (think of .git folders for example, and
the zillions objects in objects subfolder), for a very low benefit.

At least, @phanan https://github.com/phanan, make the ignoreDotFiles be
true by default, and let it change behaviour with an option from the env
file, and not the default.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/phanan/koel/issues/450#issuecomment-247675363, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AHrt0qytUNuSR4IF1bkFV_CEtKsTflrjks5qquG8gaJpZM4J9jzN
.

<!-- gh-comment-id:247743145 --> @phanan commented on GitHub (Sep 17, 2016): Your points are all right, except that the media folders typically don't have cache or git. But yes, the idea of the .env file makes much sense :+1: On Sat, Sep 17, 2016 at 2:36 AM, X-Ryl669 notifications@github.com wrote: > On Unix, it's a convention that folder and files starting with a '.' are > ignored. If you start including them, then you'll see a lot of "not safe > for users" garbage in the file list. Maybe it's better to rename your album > on the filesystem with something else, as this folder will also be hidden > in the standard file explorer, any standard commands (like cp \* /whatever, > ls), etc... > > Typically, having Symfony listing all those "cache" directory will make > the file listing much much slower (think of .git folders for example, and > the zillions objects in objects subfolder), for a very low benefit. > > At least, @phanan https://github.com/phanan, make the ignoreDotFiles be > true by default, and let it change behaviour with an option from the env > file, and not the default. > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > https://github.com/phanan/koel/issues/450#issuecomment-247675363, or mute > the thread > https://github.com/notifications/unsubscribe-auth/AHrt0qytUNuSR4IF1bkFV_CEtKsTflrjks5qquG8gaJpZM4J9jzN > .
Author
Owner

@phanan commented on GitHub (Sep 17, 2016):

Closing with e4f0027f6a.

<!-- gh-comment-id:247784500 --> @phanan commented on GitHub (Sep 17, 2016): Closing with e4f0027f6a37f5304f551c44347b26f2a13d0892.
Author
Owner

@X-Ryl669 commented on GitHub (Sep 18, 2016):

@phanan : Thanks for the fix. There's however a small spelling mistake (it's ignoreDotFile and not ingoreDotFile).

<!-- gh-comment-id:247864925 --> @X-Ryl669 commented on GitHub (Sep 18, 2016): @phanan : Thanks for the fix. There's however a small spelling mistake (it's `ignoreDotFile` and not `ingoreDotFile`).
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
starred/koel-koel#317
No description provided.